[16.0][IMP+FIX] account_invoice_tax_required: Don't bypass restriction on mass validation + better message #1643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…validation If you use the action in the invoice list for doing mass validation, the restriction about taxes required is bypassed. That's because the mass validation wizard is not calling `action_post`, but directly `_post`. TT47059
…blem If doing mass validation, and a missing tax error appears, you don't know on which invoice is the problem, so let's improve the message for indicating it. PO files + translations have been adapted as well for smoother transition and avoid extra work by the translators. TT47059
pedrobaeza
requested review from
carlosdauden and
carolinafernandez-tecnativa
carolinafernandez-tecnativa
approved these changes
Jan 11, 2024
carlosdauden
approved these changes
Jan 12, 2024
|
/ocabot merge patch |
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at 99cfcfc. Thanks a lot for contributing to OCA. ❤️ |
pedrobaeza
deleted the
16.0-fix-account_invoice_tax_required-mass_validation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forward-port of #1642
If you use the action in the invoice list for doing mass validation, the restriction about taxes required is bypassed. That's because the mass validation wizard is not calling
action_post, but directly_post. It includes a regression test.A second commit improves the message, indicating the affected invoice.
@Tecnativa TT47059