Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17.0][MIG]account_move_tier_validation: Migration to v17.0 #1634

Closed
wants to merge 20 commits into from
Closed

[17.0][MIG]account_move_tier_validation: Migration to v17.0 #1634

wants to merge 20 commits into from

Conversation

moitabenfdz
Copy link

@moitabenfdz moitabenfdz commented Dec 29, 2023 •
edited
Loading

pegonzalezspesol and others added 18 commits December 29, 2023 11:47
@pegonzalezspesol @moitabenfdz
[ADD] 13.0 account_move_tier_validation
f12b839
@dong-z @moitabenfdz
Added translation using Weblate (Chinese (Simplified))
42921fb
@moitabenfdz
[FIX] RecursionError
d9194f8
@MiquelRForgeFlow @moitabenfdz
[UPD] Eficent -> ForgeFlow
b5c9eb2
@newtratip @moitabenfdz
[MIG] account_move_tier_validation: Migration to 14.0
8d4b6e0
@tomassainz @moitabenfdz
Added translation using Weblate (Spanish)
e5dd4b3
@JordiBForgeFlow @moitabenfdz
[13.0][imp][account_move_tier_validation] Adds a new filters
416dde2 
* 'Validation In Progress' so as to allow an easy location of the
   invoices for which a validation has been triggered,
   but it is not yet completed.
* 'Validation Not Started' to locate bills that either require
   no validation, or the request for validation has not yet been initiated.
@JordiBForgeFlow @moitabenfdz
[account_move_tier_validation][fix] fixes search 'Validation Not Star…
74c94cc 
…ted'
@JordiBForgeFlow @moitabenfdz
[account_move_tier_validation][fix] filter Validation Not Started is …
3fab594 
…not working correctly
@extrememicro @moitabenfdz
Added translation using Weblate (Catalan)
fc62178
@simonstromb @moitabenfdz
Added translation using Weblate (Swedish)
72be306
@vvrossem @moitabenfdz
[MIG][15.0] account_move_tier_validation
bf869ed
@JordiBForgeFlow @moitabenfdz
[IMP] account_move_tier_validation: Use field messages for review, va…
43d4735 
…lidation, rejection
@bobslee @moitabenfdz
[15.0][IMP] account_move_tier_validation: add filter "No Validation R…
4bd7ca8 
…equested"
@hbrunn @moitabenfdz
[MIG] account_move_tier_validation to 16.0
1940017
@Ivorra78 @moitabenfdz
Translated using Weblate (Spanish)
c82dad1 
Currently translated at 100.0% (26 of 26 strings)

Translation: account-invoicing-16.0/account-invoicing-16.0-account_move_tier_validation
Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-16-0/account-invoicing-16-0-account_move_tier_validation/es/
@moitabenfdz
[IMP] account_move_tier_validation: pre-commit stuff
8487c55
@moitabenfdz
[MIG] account_move_tier_validation: Migration to 17.0
75de733
@moitabenfdz moitabenfdz force-pushed the 17.0-mig-account_move_tier_validation branch from ebfa885 to d185a63 Compare December 29, 2023 11:19
@moitabenfdz moitabenfdz force-pushed the 17.0-mig-account_move_tier_validation branch from d185a63 to 75de733 Compare January 10, 2024 08:23
cormaza
cormaza approved these changes Jan 13, 2024
View reviewed changes
Copy link

@cormaza cormaza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bosd
bosd approved these changes Feb 17, 2024
View reviewed changes
Copy link
Contributor

@bosd bosd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; the maturity level can be set to Production/Stable

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@rven
Copy link
Contributor

rven commented Mar 7, 2024

Could this be merged?

celm1990
celm1990 approved these changes Apr 17, 2024
View reviewed changes
Copy link

@celm1990 celm1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@moitabenfdz
Copy link
Author

@fclementic2c @grindtildeath @sbidoul Can I get some help to get this merged?

bizzappdev
bizzappdev approved these changes Apr 18, 2024
View reviewed changes
Copy link

@bizzappdev bizzappdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@patrickrwilson
Copy link

@moitabenfdz I know this is approved but it won't work correctly without this same fix that is in this PR for v16. #1703
Can this be applied to this PR?

@rven rven mentioned this pull request May 30, 2024
Open
46 tasks
@moitabenfdz
Copy link
Author

@fclementic2c @sbidoul @rafaelbn Can I get this merged, please?

@SonoDavid
Copy link

To remove a standard Odoo warning, you could remove the first line of 'index.html'.
The xml version description is not necessary any more and since version 17 issues a warning in console.

@mylbco
Copy link

mylbco commented Jul 19, 2024

Can this be merged ?

@StefanRijnhart
Copy link
Member

Not to block this but including #1703 seems a little premature. It has not received any reviews when I looked just now.
Please rename your commit [FIX]Delete xml version to include the module name: [FIX] account_move_tier_validation: delete XML version.

@StefanRijnhart
Copy link
Member

I'm convinced now by the test that is now added to #1703. Maybe you can re-pick the commit of that PR?

@BT-etejeda
Copy link

Hi @moitabenfdz , any progress? Could you attend the comments from @StefanRijnhart ?

@mylbco
Copy link

mylbco commented Oct 31, 2024

Can this be merged ?

@luc-demeyer
Copy link

I have tested the module and deployed at a customer site.
Imho it can be merged (with or without cherry-pick of #1703 )

@StefanRijnhart StefanRijnhart mentioned this pull request Nov 1, 2024
Merged
@StefanRijnhart
Copy link
Member

Superseded by #1829 to include the final version of #1703

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cormaza cormaza cormaza approved these changes

@bizzappdev bizzappdev bizzappdev approved these changes

@luc-demeyer luc-demeyer luc-demeyer approved these changes

@celm1990 celm1990 celm1990 approved these changes

@bosd bosd bosd approved these changes

Assignees
No one assigned
Labels
approved ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.