[17.0][MIG] account_invoice_fiscal_position_update: Migration to 17.0 #1630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/ocabot migration account_invoice_fiscal_position_update |
MarwanBHL
approved these changes
Jun 17, 2024
rov-adhoc
approved these changes
Jul 1, 2024
|
@moitabenfdz Hi! Do you know why runboat is still pending? |
@rov-adhoc the last commit to this PR is very old, so the runboat build has likely been evicted to make room for others. |
|
@moitabenfdz Hey could you please rebase this pr? Regards |
|
functional review OK |
miguel-S73
approved these changes
Nov 7, 2024
|
@moitabenfdz Hi! could you rebase this PR? runboat is in pending. Thanks!! |
…on, tax mapping could be wrong set
Currently translated at 100,0% (4 of 4 strings) Translation: account-invoicing-11.0/account-invoicing-11.0-account_invoice_fiscal_position_update Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-11-0/account-invoicing-11-0-account_invoice_fiscal_position_update/nl_NL/
Currently translated at 100,0% (4 of 4 strings) Translation: account-invoicing-11.0/account-invoicing-11.0-account_invoice_fiscal_position_update Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-11-0/account-invoicing-11-0-account_invoice_fiscal_position_update/de/
Currently translated at 100.0% (4 of 4 strings) Translation: account-invoicing-12.0/account-invoicing-12.0-account_invoice_fiscal_position_update Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-12-0/account-invoicing-12-0-account_invoice_fiscal_position_update/de/
Currently translated at 100.0% (4 of 4 strings) Translation: account-invoicing-12.0/account-invoicing-12.0-account_invoice_fiscal_position_update Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-12-0/account-invoicing-12-0-account_invoice_fiscal_position_update/pt_BR/
Currently translated at 100.0% (4 of 4 strings) Translation: account-invoicing-13.0/account-invoicing-13.0-account_invoice_fiscal_position_update Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-13-0/account-invoicing-13-0-account_invoice_fiscal_position_update/nl/
Currently translated at 100.0% (4 of 4 strings) Translation: account-invoicing-13.0/account-invoicing-13.0-account_invoice_fiscal_position_update Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-13-0/account-invoicing-13-0-account_invoice_fiscal_position_update/es/
…xes after changed
…s without comments or notes.
… taxes when this was changed. Otherwise the taxes are not changed when change the fpos.
Don't create new variant, just use the default one.
Currently translated at 100.0% (6 of 6 strings) Translation: account-invoicing-16.0/account-invoicing-16.0-account_invoice_fiscal_position_update Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-16-0/account-invoicing-16-0-account_invoice_fiscal_position_update/hr/
Currently translated at 100.0% (6 of 6 strings) Translation: account-invoicing-16.0/account-invoicing-16.0-account_invoice_fiscal_position_update Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-16-0/account-invoicing-16-0-account_invoice_fiscal_position_update/es/
Currently translated at 100.0% (6 of 6 strings) Translation: account-invoicing-16.0/account-invoicing-16.0-account_invoice_fiscal_position_update Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-16-0/account-invoicing-16-0-account_invoice_fiscal_position_update/pt_BR/
…fiscal position with a line without product and description
moitabenfdz
force-pushed
the
17.0-mig-account_invoice_fiscal_position_update
branch
from
06d9f3d to
4fc78da
Compare
|
This module (account_invoice_fiscal_position_update) is messing up with the new tests in account_invoice_section_sale_order, added in v17.0. |
legalsylvain
suggested changes
Jan 30, 2025
There was a problem hiding this comment.
Hi @moitabenfdz Thanks a lot for porting this module.
I Just tested on runboat. The bug described in this issue looks to be still present. could you take a look ? Thanks !
|
@juancarlosonate-tecnativa #1678 was solved independently in commit ' [FIX]account_invoice_fiscal_position_update: fix error when changing fiscal position with a line without product and description'. @moitabenfdz you can solve #1896 by cherry-picking this commit that was just merged in 18.0: b0d75e2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.