Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] Add message to merged invoice #1629

Open
wants to merge 1 commit into
base: 14.0
Choose a base branch
from

Conversation

barkat-matthias
Copy link

@barkat-matthias barkat-matthias commented Dec 19, 2023

Using message_post to add info of the merged invoices to the new invoice

@barkat-matthias barkat-matthias force-pushed the add_post_message_on_do_merge branch from 74af8ae to ceac354 Compare December 19, 2023 09:55
Copy link
Member

@damdam-s damdam-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

Copy link
Contributor

@petrus-v petrus-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for that

@rousseldenis
Copy link
Contributor

@barkat-matthias Thanks for this. Could you add module name in your commit message (like [IMP] account_invoice_merge: ...) ?

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@barkat-matthias barkat-matthias force-pushed the add_post_message_on_do_merge branch from ceac354 to c935c6d Compare September 12, 2024 08:44
@barkat-matthias barkat-matthias force-pushed the add_post_message_on_do_merge branch from c935c6d to 896a7cd Compare September 12, 2024 08:51
@petrus-v
Copy link
Contributor

Hi @rousseldenis,

Matthias changed the commit message. Is it ready to merge now?

Regards,

@petrus-v
Copy link
Contributor

Dear @OCA/accounting-maintainers,

This received an approved label, anyone present to merge it would be lovely!

Thanks a lot for your time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants