Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17.0][MIG] account_invoice_triple_discount: Migration to 17.0 #1626

Open
wants to merge 15 commits into
base: 17.0
Choose a base branch
from
Open

[17.0][MIG] account_invoice_triple_discount: Migration to 17.0 #1626

wants to merge 15 commits into from

Conversation

ramiadavid
Copy link
Contributor

No description provided.

chienandalu and others added 14 commits December 13, 2023 23:52
@chienandalu @ramiadavid
account_invoice_triple_discount: New module
edd407b
@pedrobaeza @ramiadavid
account_invoice_triple_discount: Some improvements
09ada46
@xavierjimenez @ramiadavid
account_invoice_triple_discount
857d837
@Nikul-Chaudhary @ramiadavid
[MIG] account_invoice_triple_discount v11 to v12
63fe9ae
@benwillig @ramiadavid
[MIG] account_invoice_triple_discount to v13
1aa7c0f
@ferran-S73 @ramiadavid
[IMP] account_invoice_triple_discount: black, isort, prettier
a6ebf4d
@OCA-git-bot @ramiadavid
[14.0][MIG] account_invoice_triple_discount: Migration to V14
1d34048
@dreispt @ramiadavid
[FIX] account_invoice_triple_discount: Developer Mode was required to…
ddaa853 
… use discounts
@OCA-git-bot @ramiadavid
[IMP] update dotfiles
c3c4bd4
@ramiadavid
[MIG] account_invoice_triple_discount: Migration to 15.0
24095ee
@ramiadavid
[FIX] account_invoice_triple_discount: fix precision when compute tax…
12a9fed 
… with discount

(cherry picked from commit 5afdb21)
@ramiadavid
[MIG] account_invoice_triple_discount: Migration to 16.0
1e7b326
@ramiadavid
[FIX][16.0] account_invoice_triple_discount : Error when print reports
45f3d67
@ramiadavid
[IMP] account_invoice_triple_discount: pre-commit auto fixes
1aef565
@ramiadavid ramiadavid mentioned this pull request Dec 13, 2023
Open
46 tasks
@ramiadavid ramiadavid force-pushed the 17.0-mig-account_invoice_triple_discount branch from f7b0606 to 615cb74 Compare December 13, 2023 23:17
@ramiadavid ramiadavid marked this pull request as ready for review December 13, 2023 23:20
@sbidoul
Copy link
Member

sbidoul commented Dec 14, 2023

/ocabot migration account_invoice_triple_discount

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Dec 14, 2023
@nb-obs
Copy link

nb-obs commented Jan 16, 2024

Hello guys, As I see module is not available on website. Is there any update on this module? Any kind of help is appreciated.

@ramiadavid ramiadavid mentioned this pull request Apr 7, 2024
Open
1 task
@salvorapi
Copy link

@sbidoul please, can you merge this on 17.0 branch ? thank you, Salvo.

@Boxnia Boxnia mentioned this pull request May 28, 2024
Closed
Boxnia
Boxnia approved these changes May 28, 2024
View reviewed changes
Copy link

@Boxnia Boxnia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sbidoul
Copy link
Member

sbidoul commented May 28, 2024

@sbidoul please, can you merge this on 17.0 branch ? thank you, Salvo.

I'm not a contributor nor an expert on this module, so I'll let those who know take care of that.

salvorapi
salvorapi approved these changes May 28, 2024
View reviewed changes
Copy link

@salvorapi salvorapi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

legalsylvain
legalsylvain suggested changes Jun 6, 2024
View reviewed changes
Copy link
Contributor

@legalsylvain legalsylvain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi. I think that the huge simplication introduced by #1638 should be integrated in the version 17.

@ramiadavid could you review it ?

thanks

@ramiadavid
Copy link
Contributor Author

@legalsylvain I'm waiting for the PR to be done

@legalsylvain
Copy link
Contributor

@legalsylvain I'm waiting for the PR to be done

your review is welcome !

@rousseldenis
Copy link
Contributor

rousseldenis commented Jul 17, 2024 •
edited
Loading

@ramiadavid @legalsylvain @Boxnia IMHO, the proposal to refactor triple discount modules in v16 should be reviewed and attended before merging v17 : #1638 and OCA/sale-workflow#2885

@ferran-S73
Copy link
Contributor

@ramiadavid please add commit 2a2b975 which was merged in v16

antoniocanovas
antoniocanovas approved these changes Oct 4, 2024
View reviewed changes
Copy link

@antoniocanovas antoniocanovas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review OK !!

@legalsylvain
Copy link
Contributor

@ramiadavid @legalsylvain @Boxnia IMHO, the proposal to refactor triple discount modules in v16 should be reviewed and attended before merging v17 : #1638 and OCA/sale-workflow#2885

indeed. merge of #1638 is still pending.

@dalonsod dalonsod mentioned this pull request Nov 12, 2024
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@legalsylvain legalsylvain legalsylvain requested changes

@salvorapi salvorapi salvorapi approved these changes

@antoniocanovas antoniocanovas antoniocanovas approved these changes

@Boxnia Boxnia Boxnia approved these changes

@david-s73 david-s73 david-s73 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
17.0
Development

Successfully merging this pull request may close these issues.