Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD] [15.0] account_invoice_discount_date: Early Payment Discount Date #1625

Conversation

Shide
Copy link
Contributor

@Shide Shide commented Dec 12, 2023

Add early discount date to move lines and invoices as Odoo 17 does.

This module must be deprecated in Odoo 17.

https://www.loom.com/share/13eca4ab1e3d4790938b518eee39a654?sid=eaf99617-a10b-4f36-9d29-036f43aa7e2b

MT-4074 @moduon @rafaelbn @yajo @EmilioPascual please review if you want :)

@rafaelbn rafaelbn added this to the 15.0 milestone Dec 12, 2023
Copy link
Member

@rafaelbn rafaelbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Designed, worked and reviewed 👍🏼

This PR is the conclusion of a big work and deeply analysed around the new functionality en Odoo 17 for this Stuff (that is great).

https://www.odoo.com/documentation/17.0/es/applications/finance/accounting/customer_invoices/cash_discounts.html

README @Shide is wonderful! Thank you for this lovely work! ❤️

Copy link

@fcvalgar fcvalgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review

LGTM, thank you @Shide

Copy link

@Gelojr Gelojr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Shide Shide force-pushed the 15.0-account_invoice_discount_date-account_invoice_discount_date branch from a874205 to 0dceb71 Compare December 14, 2023 11:31
@Shide Shide requested a review from yajo December 14, 2023 11:32
Copy link
Member

@yajo yajo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

Sorry @yajo you are not allowed to merge.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

@rafaelbn
Copy link
Member

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 15.0-ocabot-merge-pr-1625-by-rafaelbn-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit fa76f0c into OCA:15.0 Dec 14, 2023
6 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at e20f05a. Thanks a lot for contributing to OCA. ❤️

@Shide Shide deleted the 15.0-account_invoice_discount_date-account_invoice_discount_date branch December 15, 2023 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants