Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[15.0][MIG] account_move_substate #1595

Merged
merged 7 commits into from
Sep 30, 2024
Merged

[15.0][MIG] account_move_substate #1595

merged 7 commits into from
Sep 30, 2024

Conversation

bosd
Copy link
Contributor

@bosd bosd commented Nov 6, 2023

standard migration

@bosd bosd mentioned this pull request Nov 7, 2023
Merged
@bosd
Copy link
Contributor Author

bosd commented Nov 7, 2023

@Saran440 Can you please review this one as well?

@bosd
Copy link
Contributor Author

bosd commented Nov 11, 2023 •
edited
Loading

@Draynyel-bosd Can you please review?

@Saran440
Copy link
Member

@bosd I think we should review v14 first #1001
and after merged, you can rebase that you commit for improved code to v15
Selection_004

@bosd
Copy link
Contributor Author

bosd commented Nov 14, 2023

@bosd I think we should review v14 first #1001

Actually, that one is superseeded by #1594.
In the ideal world, yes, we would start on V14 and forward migrate it to 17.
However, client needed it on V16. So V16 is/was the priority.

The other versions / PR are bonus. added them, in case somebody wants to merge them.

Dranyel-Bosd
Dranyel-Bosd approved these changes Nov 14, 2023
View reviewed changes
Copy link

@Dranyel-Bosd Dranyel-Bosd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review 👍

bofiltd
bofiltd approved these changes Nov 27, 2023
View reviewed changes
Copy link

@bofiltd bofiltd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@bosd
Copy link
Contributor Author

bosd commented Apr 18, 2024

@etobella V16 is already merged. Can you please merge this one as well?

@etobella
Copy link
Member

/ocabot rebase

@OCA-git-bot
Copy link
Contributor

Congratulations, PR rebased to 15.0.

@OCA-git-bot OCA-git-bot force-pushed the 15.0-mig-account_move_substate branch from 407d82d to 81332a3 Compare April 18, 2024 07:47
etobella
etobella reviewed Apr 18, 2024
View reviewed changes
Copy link
Member

@etobella etobella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am unable to test it using README on runboat. Can you review the readme please?

account_move_substate/readme/DESCRIPTION.rst Outdated Show resolved Hide resolved
@bosd bosd force-pushed the 15.0-mig-account_move_substate branch 2 times, most recently from d83ab73 to f7af089 Compare April 27, 2024 18:51
@bosd bosd mentioned this pull request Apr 27, 2024
Merged
@bosd
Copy link
Contributor Author

bosd commented Jul 9, 2024

@etobella The description is updated. I think this one is ready now.

@bosd bosd changed the title [15.0][MIG] account move substate [15.0][MIG] account_move_substate Jul 9, 2024
@bosd
Copy link
Contributor Author

bosd commented Jul 9, 2024

/ocabot migration account_move_substate

@OCA-git-bot
Copy link
Contributor

Sorry @bosd you are not allowed to mark the addon tobe migrated.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

@etobella
Copy link
Member

etobella commented Jul 9, 2024

/ocabot rebase
/ocabot migration account_move_substate

@OCA-git-bot OCA-git-bot added this to the 15.0 milestone Jul 9, 2024
@OCA-git-bot
Copy link
Contributor

Congratulations, PR rebased to 15.0.

@OCA-git-bot OCA-git-bot force-pushed the 15.0-mig-account_move_substate branch from f7af089 to 6810b28 Compare July 9, 2024 06:05
@OCA-git-bot OCA-git-bot mentioned this pull request Jul 9, 2024
Open
56 tasks
etobella
etobella reviewed Jul 9, 2024
View reviewed changes
Copy link
Member

@etobella etobella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bosd, I don't see the documentation commit 🤔

We also found a nitpicking documentation mistake.

account_move_substate/readme/USAGE.rst Outdated Show resolved Hide resolved
@bosd
Copy link
Contributor Author

bosd commented Jul 9, 2024

I don't see the documentation commit 🤔

it's here e9bc9d4

@bosd bosd mentioned this pull request Jul 9, 2024
Open
@bosd bosd force-pushed the 15.0-mig-account_move_substate branch from 6810b28 to 28cdc8c Compare July 9, 2024 08:46
@bosd bosd requested a review from etobella July 9, 2024 11:29
@bosd bosd mentioned this pull request Jul 17, 2024
Closed
@bosd
Copy link
Contributor Author

bosd commented Sep 30, 2024

@etobella is it ok now?

@yvaucher
Copy link
Member

/ocabot rebase

@OCA-git-bot
Copy link
Contributor

Congratulations, PR rebased to 15.0.

@OCA-git-bot OCA-git-bot force-pushed the 15.0-mig-account_move_substate branch from 28cdc8c to 95dc4eb Compare September 30, 2024 14:10
@yvaucher
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 15.0-ocabot-merge-pr-1595-by-yvaucher-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit e94d186 into OCA:15.0 Sep 30, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 9f52be9. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bofiltd bofiltd bofiltd approved these changes

@Dranyel-Bosd Dranyel-Bosd Dranyel-Bosd approved these changes

@etobella etobella Awaiting requested review from etobella

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
15.0
Development

Successfully merging this pull request may close these issues.
8 participants
@bosd @Saran440 @OCA-git-bot @etobella @yvaucher @bofiltd @Dranyel-Bosd @ps-tubtim