-
-
Notifications
You must be signed in to change notification settings - Fork 701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][FIX] account_invoice_pricelist_sale: lost price list to create invoce of sale refund #1497
base: 16.0
Are you sure you want to change the base?
Conversation
6735a8a
to
4c1fc33
Compare
…ce of sale refund
4c1fc33
to
b2a11f9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functional Review LGTM
The pricelist is transferred to the credit note when you create it
https://www.awesomescreenshot.com/video/29455484?key=c07a2301dc6d5a987e69d52bce94fbcc
If the credit note is created from the sale order, the price list is also transferred to the credit note
https://www.awesomescreenshot.com/video/29455629?key=73e4d9a91a26c720b67049190700a706
This PR has the |
def action_switch_invoice_into_refund_credit_note(self): | ||
self = self.with_context(aml_no_recompute_price_unit=True) | ||
return super().action_switch_invoice_into_refund_credit_note() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
def action_switch_invoice_into_refund_credit_note(self): | |
self = self.with_context(aml_no_recompute_price_unit=True) | |
return super().action_switch_invoice_into_refund_credit_note() | |
def action_switch_invoice_into_refund_credit_note(self): | |
return super( | |
AccountMove, | |
self.with_context(aml_no_recompute_price_unit=True) | |
).action_switch_invoice_into_refund_credit_note() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this better?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is more clear, also avoids redefining self.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested, it solves issue.
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
No description provided.