Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][FIX] account_invoice_pricelist_sale: lost price list to create invoce of sale refund #1497

Open
wants to merge 1 commit into
base: 16.0
Choose a base branch
from

Conversation

RodrigoBM
Copy link

@RodrigoBM RodrigoBM commented Jun 27, 2023

No description provided.

@RodrigoBM
Copy link
Author

ping @nguyenminhchien @StephaneMangin

@RodrigoBM RodrigoBM changed the title [FIX] account_invoice_pricelist_sale: lost price list to create invoce of sale refund [16.0][FIX] account_invoice_pricelist_sale: lost price list to create invoce of sale refund Sep 4, 2023
@RodrigoBM RodrigoBM force-pushed the 16.0-fix-account_invoice_pricelist_sale-lost-pricelist_id-sale-refund-fl_670 branch from 6735a8a to 4c1fc33 Compare June 24, 2024 08:15
@RodrigoBM RodrigoBM force-pushed the 16.0-fix-account_invoice_pricelist_sale-lost-pricelist_id-sale-refund-fl_670 branch from 4c1fc33 to b2a11f9 Compare July 9, 2024 16:05
Copy link

@PabloMartFL PabloMartFL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional Review LGTM

The pricelist is transferred to the credit note when you create it
https://www.awesomescreenshot.com/video/29455484?key=c07a2301dc6d5a987e69d52bce94fbcc

If the credit note is created from the sale order, the price list is also transferred to the credit note
https://www.awesomescreenshot.com/video/29455629?key=73e4d9a91a26c720b67049190700a706

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Comment on lines +22 to +24
def action_switch_invoice_into_refund_credit_note(self):
self = self.with_context(aml_no_recompute_price_unit=True)
return super().action_switch_invoice_into_refund_credit_note()

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
def action_switch_invoice_into_refund_credit_note(self):
self = self.with_context(aml_no_recompute_price_unit=True)
return super().action_switch_invoice_into_refund_credit_note()
def action_switch_invoice_into_refund_credit_note(self):
return super(
AccountMove,
self.with_context(aml_no_recompute_price_unit=True)
).action_switch_invoice_into_refund_credit_note()

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this better?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is more clear, also avoids redefining self.

Copy link
Contributor

@ajaniszewska-dev ajaniszewska-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested, it solves issue.

Copy link

github-actions bot commented Feb 2, 2025

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Feb 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants