-
Notifications
You must be signed in to change notification settings - Fork 27
resize images to 1024 on wide side #135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
but if the web pages that use these already set the image sizes explicitly, and they are not 1024, will they still look good? |
|
The only problem will be if any of the explicit sizes are larger than 1024, do you know if that's the case? |
|
i don't know offhand, but it's possible... |
|
Based on quickly grepping through our files, it seems that the only images that have set image sizes do so using relative declarations, i.e. But in any case, I checked and our container-width for content is at most 750px ( |
|
Sounds good. I have a grant proposal TODAY and need to stop looking at this now but you can merge and I'll check things later. |
|
Sounds good, not at a computer right now to check though. |
|
No worries, we don't need to rush |
|
Is GitHub confusing things, or have smaller images like Can you see an easy way to do PNG to JPEG where the associated MD files would have to change too? Maybe a |
|
Oh, good catch for those images that weren't actually resized. What happens is: those images were >300 kb, so the one-liner tried to resize them, but as they were already <1024px on the widest, they were left unchanged in terms of size. But, given how JPGs work, the compression algorithm still "changed" the file when saving it again. In theory this leads to compression artifacts if one does this again and again, but I think it's fine here for the one-off edit we made. I'll have a look for the PNG to JPEG edits! |
|
Okay, short answer is no: The problem is that we got png files in the old |
|
That's what I feared for PNG to JPG - but given the number of large PNGs a less automated solution is fine. |
|
Shall we do that work in a separate PR though? |
No description provided.