Skip to content

3.3 - test case improvement suggested by @mikekistler #5049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: v3.3-dev
Choose a base branch
from
Open

3.3 - test case improvement suggested by @mikekistler #5049

wants to merge 1 commit into from
+2 −2

Conversation

ralfhandl
Copy link
Contributor

Our schemas traditionally allow patch versions that don't exist yet. Call this out in test case.

  • no schema changes are needed for this pull request

@ralfhandl ralfhandl requested a review from mikekistler October 19, 2025 17:22
@ralfhandl ralfhandl mentioned this pull request Oct 19, 2025
Merged
1 task
mikekistler
mikekistler previously approved these changes Oct 19, 2025
View reviewed changes
Copy link
Contributor

@mikekistler mikekistler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 👍

@ralfhandl ralfhandl deleted the branch OAI:v3.3-dev October 19, 2025 18:18
@ralfhandl ralfhandl closed this Oct 19, 2025
@ralfhandl ralfhandl reopened this Oct 19, 2025
@ralfhandl ralfhandl changed the base branch from v3.3-dev-start-3.3.0 to v3.3-dev October 19, 2025 18:23
@ralfhandl ralfhandl dismissed mikekistler’s stale review October 19, 2025 18:23

The base branch was changed.

@ralfhandl ralfhandl requested a review from mikekistler October 19, 2025 18:23
@ralfhandl
Copy link
Contributor Author

@mikekistler Sorry to re-request your review, I had to change the base branch to v3.3-dev which auto-dismissed your review (as it should).

@ralfhandl ralfhandl marked this pull request as ready for review October 19, 2025 18:25
@ralfhandl ralfhandl requested review from a team as code owners October 19, 2025 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mikekistler mikekistler Awaiting requested review from mikekistler

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ralfhandl @mikekistler