-
Notifications
You must be signed in to change notification settings - Fork 9.1k
v3.2-dev: update from dev #4787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: v3.2-dev
Are you sure you want to change the base?
Conversation
Switch to @hyperjump/json-schema-coverage for schema test coverage
Update MAINTAINERS.md
Needs to be merged first |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ralfhandl I would prefer that we not move the testing goal posts so close to a release while a ton of PRs are in flight that have been held up for multiple moths (the encoding PR, when counting its prior iteration, is over two months old now).
I'm happy to do a pass on this after we get things merged, but I object to merging this and suddenly breaking all the PRs I have open and dramatically increasing what it takes to get them over the line. Let's get them merged then increase testing. I'm happy to delay the release for it, but I object to delaying my already long-outstanding PRs.
[not really a "request changes" so much as "request delay", but there's no radio button for that in Github]
As long as we do NOT publish the 3.2 schemas with current the sloppy test coverage I am fine with postponing this. Btw. there already is a 3.2 PR that brings coverage to 100% for the schema changes that are already merged. |
Merge
dev
intov3.2-dev
.