Skip to content

3.1.1: Improved request-response example #3998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 8, 2024
Merged

3.1.1: Improved request-response example #3998

merged 2 commits into from
Aug 8, 2024

Conversation

ralfhandl
Copy link
Contributor

@ralfhandl ralfhandl commented Aug 5, 2024 •
edited
Loading

and two more nits

Port of #3997

@ralfhandl ralfhandl added editorial Wording and stylistic issues approved pr port PRs that just port an approved PR to another version labels Aug 5, 2024
@ralfhandl ralfhandl added this to the v3.1.1 milestone Aug 5, 2024
@ralfhandl ralfhandl requested review from lornajane, handrews, mikekistler and a team August 5, 2024 16:04
@ralfhandl ralfhandl mentioned this pull request Aug 5, 2024
Closed
@ralfhandl ralfhandl changed the title Improved request-response example 3.1.1: Improved request-response example Aug 5, 2024
mikekistler
mikekistler approved these changes Aug 7, 2024
View reviewed changes
Copy link
Contributor

@mikekistler mikekistler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@ralfhandl ralfhandl requested a review from miqui August 8, 2024 12:34
lornajane
lornajane approved these changes Aug 8, 2024
View reviewed changes
Copy link
Contributor

@lornajane lornajane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

@lornajane lornajane merged commit 261e67c into OAI:v3.1.1-dev Aug 8, 2024
1 check passed
@ralfhandl ralfhandl deleted the 3.1.1/consistent-formatting branch August 8, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lornajane lornajane lornajane approved these changes

@mikekistler mikekistler mikekistler approved these changes

@handrews handrews Awaiting requested review from handrews

@miqui miqui Awaiting requested review from miqui

Assignees
No one assigned
Labels
approved pr port PRs that just port an approved PR to another version editorial Wording and stylistic issues
Projects
None yet
Milestone
v3.1.1
Development

Successfully merging this pull request may close these issues.
3 participants
@ralfhandl @lornajane @mikekistler