feat: iss#22 additional headers #23
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should solve #22.
Functionality
This will set custom default HTTP headers for fetching all future publication resources. Also applies for resources for already opened publications.
Usage
Implementation
setCustomHeaders
for flutter_readium.defaultHttpHeaders
variable, which keeps its value across requests. When setting new headers, the same object reference fordefaultHttpHeaders
is kept, but is cleared of previous headers and filled with new ones.DefaultHttpClient
when HTTP requests are made, where thedefaultHttpHeaders
are added.Limitations
openPublication
function, because there wasn't a straight forward way to connect headers to specific publications, as publication ID isn't present at the time of HTTP requests. (Correct me if I'm wrong.)DefaultHttpClient
should be used.Testing
Has been tested on Android for these scenarios:
Note!
The iOS draft code needs to be looked over and tested.