-
Notifications
You must be signed in to change notification settings - Fork 4
feat: Support for Audiobooks #20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
ddfreiling
wants to merge
30
commits into
main
Choose a base branch
from
feat/audiobook-navigator
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+1,693
−1,030
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_readium into feat/audiobook-navigator * 'feat/audiobook-navigator' of github.com:Notalib/flutter_readium: (29 commits) minnor update to isReaderReady for android review follow up chore(web): update readium dependencies to latest non beta versions chore(web): update @readium dependencies to latest versions refactor: move web from own package into flutter_readium package chor(test): mock methods match FlutterReadiumPlatform chor(example): additional publication manifest URL refactor(web): extract helper functions for fetching manifest and initializing navigator feat: add build and installation scripts feat(web): scroll up and down using keyboard refactor: simplify widget return structure in ReadiumReaderWidget for web feat: implement setDefaultPreferences method for EPUB preferences handling chore: clean up comments feat: add pageMargins to EPUB preferences handling feat(web): store default EPUB preferences in setEPUBPreferences method fix(web): preferences handling has correct vertical scroll conversion and type normalization fix(example): correct indentation for webManifestList asset in pubspec fix(locator): ensure href only contains path in Locator object feat(example): add web to example app feat(web): implement EPUB preferences handling in JsPublicationChannel and ReadiumWebView ...
loadPublication can load many manifests arbitrarily, but references are not stored
…but only openPublication should do that.
…_readium into feat/audiobook-navigator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.