Skip to content

Add {save,restore}_checkpoint to PartialPaths to rewind the arena allocator pointers #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 24, 2024

Conversation

ggiraldez
Copy link

@ggiraldez ggiraldez commented Dec 23, 2024

This allows us to use PartialPaths for a database of pre-computed minimal partial paths for resolution and reuse it to resolve many references without increasing the memory used.

@OmarTawfik OmarTawfik force-pushed the partial-paths-checkpoint branch from ff0bf65 to fd5323e Compare December 24, 2024 09:32
@OmarTawfik OmarTawfik requested review from a team as code owners December 24, 2024 09:32
Copy link

@OmarTawfik OmarTawfik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Added a couple of suggestions, to help identify the additions in any future merge from upstream.

@ggiraldez ggiraldez enabled auto-merge December 24, 2024 15:49
@ggiraldez ggiraldez added this pull request to the merge queue Dec 24, 2024
Merged via the queue into nomic with commit 9631ed9 Dec 24, 2024
20 checks passed
@ggiraldez ggiraldez deleted the partial-paths-checkpoint branch December 24, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants