add CODEOWNERS file #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggiraldez
approved these changes
Dec 23, 2024
ggiraldez
reviewed
Dec 23, 2024
CODEOWNERS
Outdated
| @@ -0,0 +1 @@ | |||
| * @NomicFoundation/Slang @NomicFoundation/SlangExtended | |||
There was a problem hiding this comment.
GitHub is complaining that these two teams not being publicly available or not having valid permissions, but they are (AFAICT). Not sure what's happening here.
But also, there is an existing CODEOWNERS file inside .github, which I think will take precedence over this one. At least that's what the documentation says.
There was a problem hiding this comment.
GitHub is complaining that these two teams not being publicly available or not having valid permissions
Turns out they were needed to be added to the repo explicitly first. Did that now.
But also, there is an existing CODEOWNERS file inside .github, which I think will take precedence over this one.
good catch. fixed!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.