fix: Ensure that Node.js native addon targets GLIBC 2.28 on x86_64-unknown-linux-gnu
#909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
OmarTawfik
reviewed
Apr 2, 2024
OmarTawfik
reviewed
Apr 2, 2024
OmarTawfik
reviewed
Apr 2, 2024
OmarTawfik
reviewed
Apr 2, 2024
OmarTawfik
reviewed
Apr 2, 2024
OmarTawfik
reviewed
Apr 2, 2024
OmarTawfik
reviewed
Apr 2, 2024
OmarTawfik
reviewed
Apr 2, 2024
OmarTawfik
reviewed
Apr 2, 2024
OmarTawfik
reviewed
Apr 2, 2024
OmarTawfik
requested changes
Apr 2, 2024
|
@OmarTawfik I've applied the feedback and separated the GLIBC-related code into a dedicated module because it deals with a single platform, so it doesn't pollute remaining modules and it got a bit bigger (added a new data type, added tests). |
OmarTawfik
reviewed
Apr 5, 2024
OmarTawfik
approved these changes
Apr 5, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 11, 2024
Fixes warnings on non-GNU systems introduced with #909 Instead of doing the conditional compilation for the remaining items that are only used for this check, the routines will be compiled in on the other systems for simplicity but only used inside a host GNU system. The alternative is to pepper `#[cfg(target_env = "gnu")]` everywhere but IMO it'd hurt readability and we're talking about the `infra` CLI, should is only executed as part of the local development, so this should be an acceptable trade-off. This was not caught in the CI as we only use a GNU host there, so naturally all of the code was compiled in. Tested with `infra ci` and `infra publish npm --dry-run` on macOS and a Linux GNU.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for NomicFoundation/hardhat-vscode#546 #639
Without this, we host-compiled our native addon with the GLIBC of the runner (
ubuntu-22.04), which is 2.33. That's too high and will cause linking issues on older, stable distributions such as Debian 11 (2.31), Debian 10 (2.28), Ubuntu 20.04 (2.31) etc.The Linux requirement for VS Code atm is 2.28 (https://code.visualstudio.com/docs/supporting/requirements#_additional-linux-requirements) and was bumped in 1.86. Prior to that, the required version was 2.17 and we might consider targeting it instead, until we bump the required VS Code engine for the shipped extension (cc @kanej).
Here is the latest runs that check that the
infra publish npm --dry-runexecutes as expected and passes the relevant checks on our CI: https://github.com/Xanewok/slang/actions/runs/8472800732/job/23215682564. The built artifacts are uploaded as part of the pipeline so they can be additionally downloaded and inspected manually for the GLIBC symbols.