-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ignition: port ignition plugin #6227
base: v-next
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
hardhatTotal size of the bundle: List of dependencies (sorted by size)
|
cc6c292
to
4edf391
Compare
1679340
to
0003363
Compare
816df90
to
d6150c4
Compare
5a55b98
to
b0a6c56
Compare
b0a6c56
to
90d7b95
Compare
In Hardhat 3 we will not expose a default `hre.ignition` object. Instead the Ignition object will only be added by the `ethers`/`viem` Ignition plugins.
Get balances was working against the wrong connection.
This was not explicitly needed before. We should investigate if something has changed in our default EDR setup.
I am unsure here as to why the addresses have changed. Maybe we are compiling with a different version of solc?
To match the rule that exports should be in the public file structure we move out those files from internal to a top level `./helpers` folder.
Swap to a single `./type-extensions.ts` file. We only add config in the plugin.
This is a direct port. There appear to be no related tests.
The visualize test requires the report to have been built. The project ref in the tsconfig is not enough, so for the moment, lets build before running the tests. This is slow. Really slow. But we can revisit this.
This is the same as set in the Hardhat 2 version.
41980d2
to
f794457
Compare
In HH2 we interacted with the ledger plugin with events. In HH3 we will leverage the hook system and user interruptions. `hardhat-ledger` has not yet been ported to HH3. We will rework the ledger integration for Ignition then. Until then we are removing the ledger related code.
f794457
to
e5dd73f
Compare
This migrates
hardhat-ignition
the Ignition Hardhat plugin to Hardhat 3.The following tasks have been ported:
verifyThe verify task shows a message that it has not been implemented:
Running Manually
The Ignition plugin has been added to the example project, along with an Ignition module. You can run a deploy with:
Tests
The tests are all passing. Three are skipped:
should deploy user interfered transaction on second run
- which is skipped in Hardhat 2 IgnitionKnown bugs
There is a known bug in the visualize report. This will be addressed in a follow up PR.
Review points
My apologies to the reviewer. The commits are targeted. Moving through them one at a time should be possible.
The commits split down into:
Follow-up tasks
""
to represent no option given by userverify
taskhardhat_setLedgerOutputEnabled - Method not supported
message on the node