Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardization of Function and Property Naming in hardhat ignition viem #6217

Closed
wants to merge 5 commits into from

Conversation

Marcofann
Copy link

This PR updates function and property names in multiple test files within the Hardhat Ignition Viem package to improve consistency and ensure alignment with correct naming conventions. The changes enhance code clarity and prevent potential misinterpretations.

Changes:

  • Updated nonexistantRead, nonexistantWrite, and nonexistantEstimatenonexistentRead, nonexistentWrite, and nonexistentEstimate across:
    • named-deployment-contract.ts
    • named-contract-at.ts
    • artifact-deployment-contract.ts
    • artifact-contract-at.ts
    • viem-results.ts

Why This Change?

Consistent naming of functions and properties is essential for maintainability and reducing potential confusion during development. This update ensures uniformity across test files, improving code readability and reducing the risk of errors.

Risks

Low – This update only affects naming conventions in test files without modifying logic or functionality.

Testing

  • Verified that all test cases reference the updated function names.
  • Confirmed that the corrections align with the intended functionality in the Hardhat Ignition Viem package.

Copy link

changeset-bot bot commented Feb 2, 2025

⚠️ No Changeset found

Latest commit: 0d0be0c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Feb 2, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hardhat ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 2, 2025 7:11pm

@alcuadrado
Copy link
Member

Hi,

Thanks for sending this PR, but we don't accept changes that can be seen as inconsequential for the project, as described here.

If you want to collaborate, we recommend you try to fix a small bug first.

@alcuadrado alcuadrado closed this Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants