Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add testFiles option to test solidity #6186

Merged
merged 1 commit into from
Jan 24, 2025
Merged

Conversation

galargh
Copy link
Member

@galargh galargh commented Jan 23, 2025

Resolved #6176

  • Because this PR includes a bug fix, relevant tests have been included.
  • Because this PR includes a new feature, the change was previously discussed on an Issue or with someone from the team.
  • I didn't do anything of this.

This introduces an option to run only a subset of solidity tests. The CLI interface I implemented is exactly the same as with the test node task.

Copy link

changeset-bot bot commented Jan 23, 2025

⚠️ No Changeset found

Latest commit: d0cc44c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Jan 23, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hardhat ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 23, 2025 9:04pm

@github-actions github-actions bot added the status:ready This issue is ready to be worked on label Jan 23, 2025
Copy link
Contributor

@ChristopherDedominici ChristopherDedominici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just a question: is it worth to add a simple test just to cover this new addition?

@galargh
Copy link
Member Author

galargh commented Jan 24, 2025

LGTM. Just a question: is it worth to add a simple test just to cover this new addition?

We're yet to set up solidity test plugin tests. For now, I created the issue for that - #6192 - and I assigned it to myself. I'll jump right on it after we clear the tasks we planned for this sprint.

@galargh galargh added this pull request to the merge queue Jan 24, 2025
Merged via the queue into v-next with commit cbac939 Jan 24, 2025
58 checks passed
@galargh galargh deleted the solidity-test-file branch January 24, 2025 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:ready This issue is ready to be worked on
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants