Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check for test networks in hardhat-network-helpers #6010

Conversation

ChristopherDedominici
Copy link
Contributor

@ChristopherDedominici ChristopherDedominici commented Dec 2, 2024

This PR ensures that every method performing an RPC request in the hardhat-network-helpers plugin verifies whether the network used for the request is a test network. If the network is not a test network, an error is thrown. This is because hardhat-network-helpers is designed to work exclusively with test networks.

Supported test networks:

  • hardhat
  • zksync
  • anvil

Copy link

vercel bot commented Dec 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hardhat ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 5, 2024 6:41pm

Copy link

changeset-bot bot commented Dec 2, 2024

⚠️ No Changeset found

Latest commit: 124fba1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

…check-for-test-networks-in-hardhat-network-helpers
@ChristopherDedominici ChristopherDedominici added no changeset needed This PR doesn't require a changeset status:ready This issue is ready to be worked on and removed status:triaging no changeset needed This PR doesn't require a changeset labels Dec 2, 2024
@ChristopherDedominici ChristopherDedominici marked this pull request as ready for review December 2, 2024 14:44
@alcuadrado alcuadrado requested a review from galargh December 3, 2024 22:07
@alcuadrado
Copy link
Member

@sz-piotr I think you can review this one to get more familiar with this plugin, as an example of a plugin that extends the network.

Copy link
Member

@galargh galargh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work 🥇 The implementation looks solid! I left a couple of comments to better understand the alternatives.

Copy link
Member

@galargh galargh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thank you for your help understanding the changeset 🙇

@ChristopherDedominici ChristopherDedominici added this pull request to the merge queue Dec 6, 2024
Merged via the queue into v-next with commit e03d452 Dec 6, 2024
65 checks passed
@ChristopherDedominici ChristopherDedominici deleted the add-check-for-test-networks-in-hardhat-network-helpers branch December 6, 2024 13:08
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
no changeset needed This PR doesn't require a changeset status:ready This issue is ready to be worked on
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Add check for test networks in hardhat-network-helpers, e.g.: ZKsync
4 participants