-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add check for test networks in hardhat-network-helpers #6010
Add check for test networks in hardhat-network-helpers #6010
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
v-next/hardhat-network-helpers/src/internal/network-helpers/network-helpers.ts
Show resolved
Hide resolved
…check-for-test-networks-in-hardhat-network-helpers
@sz-piotr I think you can review this one to get more familiar with this plugin, as an example of a plugin that extends the network. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work 🥇 The implementation looks solid! I left a couple of comments to better understand the alternatives.
v-next/hardhat-network-helpers/src/internal/network-helpers/network-helpers.ts
Show resolved
Hide resolved
v-next/hardhat-network-helpers/src/internal/network-helpers/network-helpers.ts
Outdated
Show resolved
Hide resolved
v-next/hardhat-network-helpers/src/internal/network-helpers/network-helpers.ts
Outdated
Show resolved
Hide resolved
v-next/hardhat-network-helpers/src/internal/network-helpers/time/time.ts
Show resolved
Hide resolved
v-next/hardhat-network-helpers/test/helpers/mocked-rpc-method.ts
Outdated
Show resolved
Hide resolved
v-next/hardhat-network-helpers/test/helpers/mocked-rpc-method.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Thank you for your help understanding the changeset 🙇
This PR ensures that every method performing an RPC request in the
hardhat-network-helpers
plugin verifies whether the network used for the request is atest
network. If the network is not atest
network, an error is thrown. This is becausehardhat-network-helpers
is designed to work exclusively with test networks.Supported test networks: