-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Network manager cleanup Pt1 #6003
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
48d8881
to
bf72bd8
Compare
PR Description:
This PR addresses several TODOs in the network manager and refactors interfaces for improved clarity and consistency. Key changes include:
Clarity and consistency between provider types:
EdrProvider
.HttpProvider.create
parameter types into an interface.loggerConfig
andtracingConfig
.HttpProvider
constructor private and update tests accordingly. An optionaltestDispatcher
is now passed to theHttpProvider.create
function to facilitate this change.Refactored
jsonRpcRequestWrapper
:NetworkManager
.NetworkManager
before passing it to the providers.Code cleanup in
NetworkManager
: