Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Network manager cleanup Pt1 #6003

Merged
merged 8 commits into from
Dec 6, 2024
Merged

Network manager cleanup Pt1 #6003

merged 8 commits into from
Dec 6, 2024

Conversation

schaable
Copy link
Member

PR Description:

This PR addresses several TODOs in the network manager and refactors interfaces for improved clarity and consistency. Key changes include:

  • Clarity and consistency between provider types:

    • Pass a configuration object to the EdrProvider.
    • Extract HttpProvider.create parameter types into an interface.
    • Set default values for loggerConfig and tracingConfig.
    • Make the HttpProvider constructor private and update tests accordingly. An optional testDispatcher is now passed to the HttpProvider.create function to facilitate this change.
  • Refactored jsonRpcRequestWrapper:

    • Eliminated duplication by moving the type definition to NetworkManager.
    • Defined the function in NetworkManager before passing it to the providers.
  • Code cleanup in NetworkManager:

    • Removed unneeded type assertion.

Copy link

changeset-bot bot commented Nov 27, 2024

⚠️ No Changeset found

Latest commit: 1f38ada

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Nov 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hardhat ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 5, 2024 7:26pm

@schaable schaable requested a review from alcuadrado November 27, 2024 14:39
@github-actions github-actions bot added the status:ready This issue is ready to be worked on label Nov 27, 2024
@schaable schaable added the v-next A Hardhat v3 development task label Dec 3, 2024
@schaable schaable added this pull request to the merge queue Dec 5, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 5, 2024
@schaable schaable added this pull request to the merge queue Dec 6, 2024
Merged via the queue into v-next with commit 58a3d31 Dec 6, 2024
45 checks passed
@schaable schaable deleted the network-manager-cleanup branch December 6, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:ready This issue is ready to be worked on v-next A Hardhat v3 development task
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants