Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing interfaces for hardhat-network-helpers #5895

Merged
merged 6 commits into from
Oct 30, 2024
Merged

Add missing interfaces for hardhat-network-helpers #5895

merged 6 commits into from
Oct 30, 2024

Conversation

ChristopherDedominici
Copy link
Contributor

@ChristopherDedominici ChristopherDedominici commented Oct 30, 2024 •
edited
Loading

HardhatNetworkHelpers should be exported as an interface in the plugin.

Changes:

  • new interfaces added: HardhatNetworkHelpers, Time, Duration
  • the functions docs have been moved from the classes to the interfaces
  • the variables that were using the classes as types now use the interfaces

@ChristopherDedominici ChristopherDedominici added the no changeset needed This PR doesn't require a changeset label Oct 30, 2024
@ChristopherDedominici ChristopherDedominici self-assigned this Oct 30, 2024
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 30, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 11731c8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Oct 30, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hardhat ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 30, 2024 11:51am

@ChristopherDedominici ChristopherDedominici changed the title Add interface for hardhat-network-helpers Add missing interfaces for hardhat-network-helpers Oct 30, 2024
@alcuadrado alcuadrado added this pull request to the merge queue Oct 30, 2024
Merged via the queue into v-next with commit c7113f9 Oct 30, 2024
15 checks passed
@alcuadrado alcuadrado deleted the add-interface-for-hh-network-helpers branch October 30, 2024 15:46
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alcuadrado alcuadrado alcuadrado approved these changes

Assignees

@kanej kanej

@ChristopherDedominici ChristopherDedominici

Labels
no changeset needed This PR doesn't require a changeset status:triaging
Projects
Hardhat
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ChristopherDedominici @alcuadrado @kanej