Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the DefaultChainType as default type parameter #5893

Merged
merged 1 commit into from
Oct 30, 2024
Merged

Use the DefaultChainType as default type parameter #5893

merged 1 commit into from
Oct 30, 2024

Conversation

alcuadrado
Copy link
Member

WDYT, @schaable ?

@alcuadrado alcuadrado requested a review from schaable October 29, 2024 22:26
@vercel Vercel
Copy link

vercel bot commented Oct 29, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hardhat ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 29, 2024 10:27pm

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 29, 2024

⚠️ No Changeset found

Latest commit: f05f5f3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the status:ready This issue is ready to be worked on label Oct 29, 2024
schaable
schaable approved these changes Oct 30, 2024
View reviewed changes
Copy link
Member

@schaable schaable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Next step should be to update the code to remove the type parameter when using NetworkConnection. But I don't think it's a priority.

@alcuadrado alcuadrado added this pull request to the merge queue Oct 30, 2024
Merged via the queue into v-next with commit 16ab415 Oct 30, 2024
48 checks passed
@alcuadrado alcuadrado deleted the default-chain-type-as-default-type-parameter branch October 30, 2024 15:21
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@schaable schaable schaable approved these changes

Assignees
No one assigned
Labels
status:ready This issue is ready to be worked on
Projects
Hardhat
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alcuadrado @schaable