Template improvements #5892
Template improvements #5892
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| describe("Lock", function () { | ||
| let networkConnection: NetworkConnection<"l1">; | ||
| describe("Lock", async function () { | ||
| const { viem, networkHelpers } = await network.connect(); |
There was a problem hiding this comment.
I think it cleans up the code. But I do find it surprising - I expect resource initialization code to be in the before/beforeEach.
I was initially concerned that this code might get run even if the describe is skipped, but I can confirm that isn't the case.
Would we use a similar pattern in the mocha template?
There was a problem hiding this comment.
mocha intentionally doesn't support that. So we can't do it there.
Maybe we can initialize the network connection on the first provider call? I think the code style improvement is massive.
There was a problem hiding this comment.
In reality, given that this is ESM, these calls can be in the top-level of the file.
|
|
||
| describe("Lock", function () { | ||
| let networkConnection: NetworkConnection<"l1">; | ||
| let networkHelpers: any; // TODO: We need to export this type in @ignored/hardhat-vnext-network-helpers |
There was a problem hiding this comment.
We need to export the NetworkHelpers as an interface in the plugin. It's now a class, but it should be a quick conversation into an interface. Slightly more involved than just copy and replace, because it has some nested objects.
This PR includes a first round of improvements to the template projects, it's still WIP, but can be merged as is.