A few messaging improvements

v-next/example-project/contracts/Counter.t.sol

@@ -21,7 +21,7 @@ contract CounterTest {
     require(counter.x() == x, "Value after calling inc x times should be x");
   }
 
-  function invariant() public {
+  function invariant() public pure {
     assert(true);
   }
 }
@@ -41,10 +41,13 @@ contract FailingCounterTest {
     for (uint8 i = 0; i < x; i++) {
       counter.inc();
     }
-    require(counter.x() == x + 1, "Value after calling inc x times should be x + 1");
+    require(
+      counter.x() == x + 1,
+      "Value after calling inc x times should be x + 1"
+    );
   }
 
-  function invariant() public {
+  function invariant() public pure {
     assert(false);
   }
 }

v-next/example-project/contracts/D.sol

@@ -1 +1,4 @@
+// SPDX-License-Identifier: UNLICENSED
+pragma solidity ^0.8.22;
+
 import "./C.sol";

v-next/example-project/contracts/WithForge.t.sol

@@ -1,3 +1,6 @@
+// SPDX-License-Identifier: UNLICENSED
+pragma solidity ^0.8.22;
+
 import "forge-std/Test.sol";
 
 contract TestContract is Test {
@@ -14,7 +17,7 @@ contract TestContract is Test {
 }
 
 contract ErrorsTest {
-  function arithmeticError(uint256 a) public {
-    uint256 a = a - 100;
+  function arithmeticError(uint256 a) public pure returns (uint256) {
+    return a - 100;
   }
 }

v-next/hardhat-mocha-test-runner/src/task-action.ts

@@ -47,7 +47,8 @@ const testWithHardhat: NewTaskActionFunction<TestActionArguments> = async (
   hre,
 ) => {
   if (!noCompile) {
-    await hre.tasks.getTask("compile").run({ quiet: true });
+    await hre.tasks.getTask("compile").run({});
+    console.log();
   }
 
   const files = await getTestFiles(testFiles, hre.config);
@@ -85,7 +86,8 @@ const testWithHardhat: NewTaskActionFunction<TestActionArguments> = async (
   }
   testsAlreadyRun = true;
 
-  console.log("Running Mocha tests");
+  // We write instead of console.log because Mocha already prints some newlines
+  process.stdout.write("Running Mocha tests");
 
   // This instructs Mocha to use the more verbose file loading infrastructure
   // which supports both ESM and CJS
@@ -99,6 +101,8 @@ const testWithHardhat: NewTaskActionFunction<TestActionArguments> = async (
     process.exitCode = 1;
   }
 
+  console.log();
+
   return testFailures;
 };
 

v-next/hardhat-node-test-runner/src/task-action.ts

@@ -56,7 +56,8 @@ const testWithHardhat: NewTaskActionFunction<TestActionArguments> = async (
   hre,
 ) => {
   if (!noCompile) {
-    await hre.tasks.getTask("compile").run({ quiet: true });
+    await hre.tasks.getTask("compile").run({});
+    console.log();
   }
 
   const files = await getTestFiles(testFiles, hre.config);
@@ -111,6 +112,8 @@ const testWithHardhat: NewTaskActionFunction<TestActionArguments> = async (
     process.exitCode = 1;
   }
 
+  console.log();
+
   return testFailures;
 };
 

v-next/hardhat/src/internal/builtin-plugins/solidity-test/task-action.ts

@@ -20,7 +20,8 @@ const runSolidityTests: NewTaskActionFunction<TestActionArguments> = async (
   hre,
 ) => {
   if (!noCompile) {
-    await hre.tasks.getTask("compile").run({ quiet: true });
+    await hre.tasks.getTask("compile").run({});
+    console.log();
   }
 
   const artifacts = await getArtifacts(hre.artifacts);
@@ -81,8 +82,9 @@ const runSolidityTests: NewTaskActionFunction<TestActionArguments> = async (
 
   if (includesFailures || includesErrors) {
     process.exitCode = 1;
-    return;
   }
+
+  console.log();
 };
 
 export default runSolidityTests;

v-next/hardhat/src/internal/builtin-plugins/solidity/build-system/build-system.ts

@@ -95,6 +95,10 @@ export class SolidityBuildSystemImplementation implements SolidityBuildSystem {
     rootFilePaths: string[],
     options?: BuildOptions,
   ): Promise<CompilationJobCreationError | Map<string, FileBuildResult>> {
+    if (options?.quiet !== true) {
+      console.log("Compiling your Solidity contracts");
+    }
+
     await this.#downloadConfiguredCompilers(options?.quiet);
 
     const compilationJobsPerFile = await this.getCompilationJobs(

v-next/hardhat/src/internal/builtin-plugins/test/task-action.ts

@@ -11,12 +11,12 @@ const runAllTests: NewTaskActionFunction<TestActionArguments> = async (
   const thisTask = hre.tasks.getTask("test");
 
   if (!noCompile) {
-    await hre.tasks.getTask("compile").run({ quiet: true });
+    await hre.tasks.getTask("compile").run({});
+    console.log();
   }
 
   for (const subtask of thisTask.subtasks.values()) {
     await subtask.run({ noCompile: true });
-    console.log();
   }
 
   if (process.exitCode !== undefined && process.exitCode !== 0) {

v-next/hardhat/src/internal/core/tasks/resolved-task.ts

@@ -144,7 +144,7 @@ export class ResolvedTask implements Task {
       const pluginId = this.actions[currentIndex].pluginId;
 
       if (
-        typeof currentAction === "string" &&
+        typeof currentAction === "function" &&
         pluginId !== undefined &&
         SHOULD_WARN_ABOUT_INLINE_TASK_ACTIONS_AND_HOOK_HANDLERS
       ) {

v-next/hardhat/templates/mocha-ethers/contracts/Counter.sol

@@ -1,5 +1,5 @@
-// SPDX-License-Identifier: MIT
-pragma solidity ^0.8.0;
+// SPDX-License-Identifier: UNLICENSED
+pragma solidity ^0.8.24;
 
 contract Counter {
   uint public x;

v-next/hardhat/templates/mocha-ethers/contracts/Counter.t.sol

@@ -1,5 +1,5 @@
-// SPDX-License-Identifier: MIT
-pragma solidity ^0.8.0;
+// SPDX-License-Identifier: UNLICENSED
+pragma solidity ^0.8.24;
 
 import "./Counter.sol";
 

v-next/hardhat/templates/mocha-ethers/contracts/WithForge.t.sol

@@ -1,3 +1,6 @@
+// SPDX-License-Identifier: UNLICENSED
+pragma solidity ^0.8.24;
+
 import "forge-std/Test.sol";
 
 contract TestContract is Test {
@@ -14,7 +17,7 @@ contract TestContract is Test {
 }
 
 contract ErrorsTest {
-  function arithmeticError(uint256 a) public {
-    uint256 a = a - 100;
+  function arithmeticError(uint256 a) public pure returns (uint256) {
+    return a - 100;
   }
 }

v-next/hardhat/templates/node-test-runner-viem/contracts/Counter.sol

@@ -1,5 +1,5 @@
-// SPDX-License-Identifier: MIT
-pragma solidity ^0.8.0;
+// SPDX-License-Identifier: UNLICENSED
+pragma solidity ^0.8.24;
 
 contract Counter {
   uint public x;

v-next/hardhat/templates/node-test-runner-viem/contracts/Counter.t.sol

@@ -1,5 +1,5 @@
-// SPDX-License-Identifier: MIT
-pragma solidity ^0.8.0;
+// SPDX-License-Identifier: UNLICENSED
+pragma solidity ^0.8.24;
 
 import "./Counter.sol";
 

v-next/hardhat/templates/node-test-runner-viem/contracts/WithForge.t.sol

@@ -1,3 +1,6 @@
+// SPDX-License-Identifier: UNLICENSED
+pragma solidity ^0.8.24;
+
 import "forge-std/Test.sol";
 
 contract TestContract is Test {
@@ -14,7 +17,7 @@ contract TestContract is Test {
 }
 
 contract ErrorsTest {
-  function arithmeticError(uint256 a) public {
-    uint256 a = a - 100;
+  function arithmeticError(uint256 a) public pure returns (uint256) {
+    return a - 100;
   }
 }