Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update inline hook handlers and task actions warning #5867

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

alcuadrado
Copy link
Member

This PR replicates our warning for inline hook handlers in task actions, but it also disables it during development mode and our CI.

@alcuadrado alcuadrado requested a review from kanej October 27, 2024 23:34
Copy link

changeset-bot bot commented Oct 27, 2024

⚠️ No Changeset found

Latest commit: 2d3b919

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Oct 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hardhat ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 28, 2024 6:42pm

@github-actions github-actions bot added the status:ready This issue is ready to be worked on label Oct 27, 2024
Copy link
Contributor

hardhat

Total size of the bundle: 225M
Total number of dependencies (including transitive): 58

List of dependencies (sorted by size)
220M	total
30M	@ignored/edr-optimism-linux-x64-musl
30M	@ignored/edr-optimism-linux-x64-gnu
27M	@ignored/edr-optimism-linux-arm64-musl
27M	@ignored/edr-optimism-linux-arm64-gnu
22M	@ignored/edr-optimism-win32-x64-msvc
21M	@ignored/edr-optimism-darwin-x64
20M	esbuild
20M	@ignored/edr-optimism-darwin-arm64
8.9M	solc
2.8M	@sentry/tracing
1.9M	@noble/curves
1.7M	undici
1.2M	@sentry/types
1.2M	@noble/hashes
932K	@sentry/node
920K	@sentry/utils
824K	zod
796K	@ignored/hardhat-vnext-utils
576K	tsx
548K	@sentry/core
504K	fast-equals
492K	@scure/bip39
460K	@ignored/edr
384K	@ignored/edr-optimism
368K	ethereum-cryptography
344K	@sentry/hub
320K	enquirer
284K	semver
268K	@ignored/hardhat-vnext-errors
188K	commander
168K	@scure/base
136K	adm-zip
128K	get-tsconfig
96K	@scure/bip32
92K	chalk
88K	tslib
88K	@sentry/minimal
84K	js-sha3
76K	agent-base
72K	@nomicfoundation/solidity-analyzer
68K	debug
64K	lru_map
64K	https-proxy-agent
60K	@ignored/hardhat-vnext-zod-utils
56K	rfdc
56K	follow-redirects
48K	memorystream
48K	command-exists
48K	ansi-colors
44K	tmp
40K	resolve-pkg-maps
36K	p-map
32K	cookie
24K	strip-ansi
24K	env-paths
24K	ansi-regex
20K	os-tmpdir
20K	ms

@alcuadrado alcuadrado added the v-next A Hardhat v3 development task label Oct 27, 2024
@alcuadrado alcuadrado force-pushed the warn-inline-task-and-hook-handlers branch from afb417a to 2d3b919 Compare October 28, 2024 18:41
Base automatically changed from edr-config-changes to v-next October 28, 2024 18:46
@alcuadrado alcuadrado added this pull request to the merge queue Oct 28, 2024
Merged via the queue into v-next with commit 9e67ea6 Oct 28, 2024
75 checks passed
@alcuadrado alcuadrado deleted the warn-inline-task-and-hook-handlers branch October 28, 2024 20:11
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status:ready This issue is ready to be worked on v-next A Hardhat v3 development task
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants