#6 #10
Merged
#6 #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One of the last couple CTR updates adjusted the way "toolbar items" were placed, and as such the margin here needed to be tweaked.
toolbarbutton.css -One of the last couple CTR updates adjusted the way "toolbar items" were placed, and as such the margin here needed to be tweaked.
bootstrap.js - now when user browses to a file, it will show the "Restore Default" button - when user clicks restore default button it will hide the button - learned: about inline option inputChanged method and setting the attribute of `oninputchanged` options.xul - added the elements for the custom label, didnt do any pref work on it yet though
bootstrap.js - forgot to set img.value attribute on addons-options-displayed so on click it wouldnt alert the path correct, it would be undfeind - needed to use setAttribute with image value as its not a real attribute on it toolbarbutton.css - i tried via css putting a "Preview: " before content before image with src attribute that is not blank BUT its not taking, i think its that xbl binding crap that @nmaier told me about when i was trying to badge toolbarbuttons
bootstrap.js - os.file to copy image to profile folder, so if user deletes image from hard drive it will still work - when change image on inline options page, it loads image for preview from disk, obiouvlsy it has to be on disk, but will do a copy and set the icon to that uri - on uninstall it deletes the copied file - because now im replacing overwriting old file, the image was caching for like a few hundred ms or a sec or so. so i had to add # + Math.radnom() to end of image path so it doesnt cache
Noitidart
added a commit
that referenced
this pull request
Jul 9, 2014
#6 and ff31+ support and custom image supoprt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and a bunch of other stuff