Skip to content

feat(gh-scanner): add github organization dependency scanner #485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

intincrab
Copy link
Contributor

No description provided.

Copy link

changeset-bot bot commented Jul 14, 2025

⚠️ No Changeset found

Latest commit: bbbbdfc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@fraxken
Copy link
Member

fraxken commented Jul 14, 2025

We don't want new workspace, just a new dedicated API in scanner is enough

@intincrab
Copy link
Contributor Author

We don't want new workspace, just a new dedicated API in scanner is enough

I should've asked first 😅

@fraxken
Copy link
Member

fraxken commented Jul 26, 2025

Sorry for the time I take to review that (I spent the last few weeks thinking where we can go with the API).

  1. Can you push the changeset?
  2. I think it would make sense to return a response similar to the Payload interface: https://github.com/NodeSecure/scanner/blob/master/workspaces/scanner/src/types.ts#L160

Maybe a new OrganizationPayload interface like

export interface Payload {
  /** Payload unique id */
  id: string;
  /** Name of the analyzed package */
  rootOrganizationName: string;
  /** Global warnings list */
  warnings: string[];
  highlighted: {
    contacts: IlluminatedContact[];
  };

  dependencies: GithubRepository[];
  /** Version of the scanner used to generate the result */
  scannerVersion: string;
  /** Vulnerability strategy name (npm, snyk, node) */
  vulnerabilityStrategy: Vulnera.Kind;
}

My idea is to find a way to combine both interfaces (maybe with a new root property level that could be either organization or project).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants