Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

simplified Chinese translations and minor #279

Merged
merged 4 commits into from
Feb 11, 2025
Merged

simplified Chinese translations and minor #279

merged 4 commits into from
Feb 11, 2025

Conversation

VeriTas-arch
Copy link
Contributor

  • Complete simplified Chinses translations (relative to en_us).
  • Add some useful tools for translators in the .github/tools folder.
    • These two scripts are mianly for checking which keys aren't translated and sorting the json keys so as to improve readability. In previous issues I think translators are frequently faced with these two tasks, and the tools can perhaps give them a hand.
  • Minor prettifying works on some markdown files.
    • Really minor changes. Simply to make them prettier in text editors.

@VeriTas-arch
simplified Chinese translations and minor
84b6234 
- Complete simplified Chinses translations (relative to en_us)
- Add some useful tools for translators
- Minor prettifying works on some markdown files.
@Noaaan Noaaan added enhancement New feature or request translations Related to the translations of the mod labels Feb 2, 2025
@Noaaan Noaaan self-assigned this Feb 2, 2025
Noaaan
Noaaan previously requested changes Feb 9, 2025
View reviewed changes
CREDITS.md Show resolved Hide resolved
PATCHNOTES.md Outdated Show resolved Hide resolved
@VeriTas-arch
changes requested by review.
126b85b 
- replace `*` in CREDITS.md with `-`
- recover PATCHNOTES.md to be unchanged
@VeriTas-arch VeriTas-arch requested a review from Noaaan February 10, 2025 08:10
@VeriTas-arch
minor fix
8468357
@VeriTas-arch
fix README
a5c7f3f 
Recover the format while trying to achieve a balance between better readability and consistency with former format.
VeriTas-arch
VeriTas-arch commented Feb 10, 2025
View reviewed changes
README.md Show resolved Hide resolved
@Noaaan
Copy link
Owner

Noaaan commented Feb 10, 2025

Translation seems fully complete. Nicely done 👍

The only things missing from it are a few langs from other mods (owo-lib and Additional Entity Attributes), but that is no concern for this PR. I did notice the new 1.21 arrow effects (wind_charged, oozing, infested, and weaving) are missing, but this is native to Mythic Metals itself. I will add the keys for those in main after this PR.

I have attached the respective vanilla translations for these as well:

tipped_arrow
tipped_arrow_1_
tipped_arrow_2_
tipped_arrow_3_

@Noaaan Noaaan dismissed their stale review February 10, 2025 19:58

Completed

@VeriTas-arch
Copy link
Contributor Author

Tks. Those missing keys can be completed in the next PR.

@Noaaan Noaaan merged commit aa23736 into Noaaan:1.21 Feb 11, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Noaaan Noaaan Noaaan approved these changes

Assignees

@Noaaan Noaaan

Labels
enhancement New feature or request translations Related to the translations of the mod
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VeriTas-arch @Noaaan