Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/hypridle: make hypridle start with graphical-session.target #347662

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

JohnRTitor
Copy link
Contributor

If we don't add the dependency explicitly, the service won't be pulled in at runtime. Link: #340874 (comment)

Closes: #347651

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

If we don't add the dependency explicitly, the service won't be pulled in
at runtime. Link: NixOS#340874 (comment)

Closes: NixOS#347651
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Oct 10, 2024
@JohnRTitor
Copy link
Contributor Author

Tested with my configuration.

❯  systemctl --user status hypridle.service
● hypridle.service - Hyprland's idle daemon
     Loaded: loaded (/etc/systemd/user/hypridle.service; enabled; preset: ignored)
    Drop-In: /nix/store/vbz308lam4ny1j73hnbvsjmzp1z3flyv-user-units/hypridle.service.d
             └─overrides.conf
     Active: active (running) since Thu 2024-10-10 10:30:23 IST; 57s ago
 Invocation: 84a63c9a172a416aa213aeda823c7586
       Docs: https://wiki.hyprland.org/Hypr-Ecosystem/hypridle
   Main PID: 2594 (hypridle)
      Tasks: 2 (limit: 17924)
     Memory: 616K (peak: 1.4M)
        CPU: 5ms
     CGroup: /user.slice/user-1000.slice/[email protected]/app.slice/hypridle.service
             └─2594 /nix/store/0bxazkddh9vlf708x3grkxvd8pz1x0li-hypridle-0.1.2/bin/hypridle

Oct 10 10:30:23 Ainz-NIX systemd[2088]: Started Hyprland's idle daemon.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Oct 10, 2024
@JohnRTitor
Copy link
Contributor Author

I'll merge this, no need to hold back a valid fix.

@JohnRTitor JohnRTitor merged commit 8396577 into NixOS:master Oct 10, 2024
27 checks passed
@JohnRTitor JohnRTitor deleted the hypridle-service-fix branch October 10, 2024 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nixos/hypridle: hypridle incorrectly starts on other DEs as it is wantedBy graphical-session.target
1 participant