framework/13-inch/intel-core-ultra-series1: revert #1358 (fix intel_vpu firmware error -2) #1568
Conversation
…tel_vpu firmware error -2)
| warnings = lib.mkIf (!config.hardware.enableRedistributableFirmware) [ | ||
| ''For Intel NPU support, set the option: hardware.enableRedistributableFirmware = true;'' | ||
| ]; |
There was a problem hiding this comment.
This is still needed I think
There was a problem hiding this comment.
I don't think the warning is needed. I am suggesting to remove the warning for two reasons:
- This cleanly reverts framework/13-inch/intel-core-ultra-series1: revert #1358 (fix intel_vpu firmware error -2) #1568, without leaving any lines behind.
- A warning specifically about "NPU support" doesn't make sense anymore, as all the lines related to the Intel NPU Driver will be removed.
Note that enableRedistributableFirmware will still work as expected: if set to false, nixpkgs will not include linux-firmware (nor the NPU driver binaries that it now contains).
That said, it's just a warning. If there is a preference to keep all warnings that were previously present, then we can keep this one.
@JohnAZoidberg: Let me know how you'd like this to be resolved!
There was a problem hiding this comment.
@Mic92: Could you please approve this PR? I'm just proposing to cleanly revert an earlier contribution of mine (because it is no longer necessary). Being out-of-sync with upstream has some obvious security implications...
3 participants
Description of changes
This reverts #1358 (framework/13-inch/intel-core-ultra-series1: fix intel_vpu firmware error -2).
The firmware is now upstreamed to linux-firmware (https://web.git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git/commit/?id=9b870dde196d030a6c8872e8965dd28a0146c990), so #1358 is no longer needed.
Right now, there is no impact to my proposed change (all this does is avoid downloading a file twice). However, it is better to use the upstreamed version in case the firmware gets updated in the future.
Things done
nixos-hardwareandimporting it via
<nixos-hardware>or Flake input