laptop: replace tlp with power-profiles-daemon #1474
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mic92
commented
May 11, 2025
Mic92
force-pushed
the
tlp
branch
2 times, most recently
from
b9cbfe9 to
2f762c9
Compare
|
Actually, ppd also has been superceded by tuned in many distros. tuned is fully compatible with ppd profiles, so it's a drop-in compatible but also a superset. |
|
AMD Linux laptop/desktop team also recommends tuned over ppd. |
|
Happy to switch to tuned once it lands in nixpkgs. |
bubuntux
reviewed
Jun 17, 2025
common/pc/laptop/default.nix
Outdated
| # https://github.com/NixOS/nixos-hardware/issues/260 | ||
| services.tlp.enable = lib.mkDefault ((lib.versionOlder (lib.versions.majorMinor lib.version) "21.05") | ||
| || !config.services.power-profiles-daemon.enable); | ||
| config.services.power-profiles-daemon.enable = lib.mkDefault config.services.tlp.enable; |
There was a problem hiding this comment.
should this be enabled when config.services.tlp.enable is false? (missing !)
meaning we need
config.services.power-profiles-daemon.enable = lib.mkDefault !config.services.tlp.enable;
instead
TLP is often no longer the best choice since firmware provides power profiles instead. That's why we are removing TLP as the default option. We may want to bring back TLP to some old hardware if it makes sense i.e. certain thinkpad modules.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TLP is often no longer the best choice since firmware provides power profiles instead. That's why we are removing TLP as the default option. We may want to bring back TLP to some old hardware if it makes sense i.e. certain thinkpad modules.
Fixes #1465