feat: add Lenovo ThinkPad P16s Intel Gen 2 #1413
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yajo
force-pushed
the
p16s
branch
2 times, most recently
from
bca0b9f to
3158e7c
Compare
Mic92
reviewed
Mar 31, 2025
| @@ -0,0 +1,8 @@ | |||
| {modulesPath, lib, ...}: { | |||
| imports = [ | |||
| (modulesPath + "/installer/scan/not-detected.nix") | |||
There was a problem hiding this comment.
nixos-hardware depends on nixos-generate-config. We try to not replace parts that can be auto-generated.
Suggested change
| (modulesPath + "/installer/scan/not-detected.nix") |
There was a problem hiding this comment.
Huh, weird. I assumed that if using this repo, I wouldn't need to depend on nixos-generate-config.
OK let me fix that.
Mic92
reviewed
Mar 31, 2025
Comment on lines
+10
to
+18
| boot.initrd.availableKernelModules = [ | ||
| "nvme" | ||
| "sd_mod" | ||
| "thunderbolt" | ||
| "usb_storage" | ||
| "usbhid" | ||
| "xhci_pci" | ||
| ]; | ||
| boot.kernelModules = ["kvm-intel"]; |
There was a problem hiding this comment.
Same as above:
Suggested change
| boot.initrd.availableKernelModules = [ | |
| "nvme" | |
| "sd_mod" | |
| "thunderbolt" | |
| "usb_storage" | |
| "usbhid" | |
| "xhci_pci" | |
| ]; | |
| boot.kernelModules = ["kvm-intel"]; |
There was a problem hiding this comment.
However, nixos-generate-config only gets this:
boot.initrd.availableKernelModules = [ "xhci_pci" "thunderbolt" "nvme" ];Should I just remove those?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@moduon MT-9339
Description of changes
Things done
nixos-hardwareandimporting it via
<nixos-hardware>or Flake input