[WIP] escape .git for tarball cache #12806
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
fetching
Mic92
commented
Mar 31, 2025
| return 0; | ||
| } | ||
|
|
||
| std::string escapeDotGit(const std::string& filename) { |
There was a problem hiding this comment.
TODO: We should only do this for the tarball cache.
There was a problem hiding this comment.
Also we need to bump the version of this cache as older version might otherwise be confused.
Mic92
commented
Mar 31, 2025
| @@ -57,6 +58,81 @@ bool operator == (const git_oid & oid1, const git_oid & oid2) | |||
| return git_oid_equal(&oid1, &oid2); | |||
| } | |||
|
|
|||
| namespace { | |||
|
|
|||
| int matchesDotPlusGit(const std::string& str) { | |||
There was a problem hiding this comment.
We need a bunch of tests here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #10575
Motivation
Context
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.