Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge fork into main repository. #58

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

NicklasWallgren
Copy link
Owner

@NicklasWallgren NicklasWallgren commented Oct 2, 2021

@izverev Hey, would it be possible to merge your contributions with the main repository?

@NicklasWallgren
Copy link
Owner Author

@izverev

@izverev
Copy link

izverev commented Feb 22, 2022

@NicklasWallgren Sorry for long answer, just saw your comment, maby some problems with github notifications.

First of all big thanks for your library! It is good replacement for mpg25 library

About merge, I tried to use DTO for many attempts, but every time I ran into problems with strict types, and in the end I switched to rawResponse, so at the moment I can't be sure that everything is clear there. If you what - next week I will investigating why I'm geting login_required, You've Been Logged Out response permanenty now, and can recheck if DTO changes works

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants