Host should be $proxy_host, not $host

[vbraun]

• $host is the Host sent by the user's browser. This is the correct setting if the service has built-in support for being proxied.

• $proxy_host is the Host as if the browser would run on the proxy. This is the correct setting if the service does not have built-in support for reverse proxies. It is also the nginx default.

• In nginx, you cannot unset the Host header. Configuring headers multiple times just sends multiple values with the http request. So there is no way to "fix" the Host by adding a custom header if it is already set.

For these reasons, Host should not be set (and default to $proxy_host). In the unlikely case that your service needs something else you can then just set a custom Host header in the GUI.

Fixes #2675

[github-actions]

PR is now considered stale. If you want to keep it open, please comment 👍

[valinet]

How is this STILL not merged? Such a design flaw just obliterates all the usefulness this program brought. PLEASE MERGE THIS and let's have it fixed at last.

[nginxproxymanagerci]

CI Error:

/bin/bash: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8)
certbot-node: Pulling from nginxproxymanager/nginx-full
Digest: sha256:eaa2ebcb50dd87557c9a8f95a3230128d94cac1ea17800261c036e59378e7d49
Status: Image is up to date for nginxproxymanager/nginx-full:certbot-node
docker.io/nginxproxymanager/nginx-full:certbot-node
�[1;34m❯ �[1;36mBuilding Frontend ...�[0m
yarn install v1.22.22
[1/4] Resolving packages...
[2/4] Fetching packages...
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.
error Command failed.
Exit code: 128
Command: git
Arguments: clone https://github.com/tabler/tabler.git /usr/local/share/.cache/yarn/v6/.tmp/e11a93799a52aa978c82015e29fbe309
Directory: /app/frontend
Output:
Cloning into '/usr/local/share/.cache/yarn/v6/.tmp/e11a93799a52aa978c82015e29fbe309'...
error: RPC failed; curl 92 HTTP/2 stream 5 was not closed cleanly: CANCEL (err 8)
error: 12027 bytes of body are still expected
fetch-pack: unexpected disconnect while reading sideband packet
fatal: early EOF
fatal: fetch-pack: invalid index-pack output

[kvchoi]

more_set_input_headers 'Host: www.domain-new.com';

Integerated nginx is openresty, that support "headers-more-nginx-module-0.37" modules.

so, you can reset the input header by command : more_set_input_headers

================

set input headers

location /foo {
set $my_host 'my dog';
more_set_input_headers 'Host: $my_host';
more_set_input_headers -t 'text/plain' 'X-Foo: bah';

 # now $host and $http_host have their new values...
 # ...

}

[KevinMitchell]

more_set_input_headers 'Host: www.domain-new.com';
...
so, you can reset the input header by command : more_set_input_headers

Not sure I understand how more_set_input_headers helps here. It looks like any custom headers I write, including more_set_input_headers, will appear in the generated conf file before the generated proxy_set_header Host $host; line. So are you saying more_set_input_headers takes precedence over any proxy_set_header statements, even if it appears before such statements?