Less ignoring of errors for PHP 8.4

NexusPHP · Jan 7, 2025 · 8baacd3 · 8baacd3
1 parent 96b58ed
commit 8baacd3
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 4 deletions.
diff --git a/.github/workflows/static-code-analysis.yml b/.github/workflows/static-code-analysis.yml
@@ -26,7 +26,8 @@ jobs:
       fail-fast: false
       matrix:
         php-version:
-          - 8.3
+          - '8.3'
+          - '8.4'
 
     name: Static Code Analysis
     runs-on: ubuntu-24.04
@@ -102,6 +103,8 @@ jobs:
 
       - name: Check - PHP-CS-Fixer
         run: composer cs:check
+        env:
+          PHP_CS_FIXER_IGNORE_ENV: ${{ matrix.php-version == '8.4' && '1' || ''}}
 
       - name: Check - PHPStan
         run: composer phpstan:check
diff --git a/.github/workflows/unit-tests.yml b/.github/workflows/unit-tests.yml
@@ -59,7 +59,6 @@ jobs:
         shell: bash
         run: |
           echo "COMPOSER_CACHE_DIR=$(composer config cache-dir)" >> $GITHUB_OUTPUT
-          echo "EXPERIMENTAL_FLAG=${{ matrix.php-version == '8.4' && '--ignore-platform-req=php' || '' }}" >> $GITHUB_OUTPUT
 
       - name: Cache Composer dependencies
         uses: actions/cache@v4
@@ -71,7 +70,7 @@ jobs:
             ${{ github.workflow }}-PHP_${{ matrix.php-version }}-
 
       - name: Install dependencies
-        run: composer update --ansi ${{ steps.globals.outputs.EXPERIMENTAL_FLAG }}
+        run: composer update --ansi
 
       - name: Run Unit Tests
         shell: bash

diff --git a/phpstan.dist.neon b/phpstan.dist.neon
@@ -4,7 +4,9 @@ includes:
   - src/Nexus/PHPStan/extension.neon
 
 parameters:
-  phpVersion: 80300
+  phpVersion:
+    min: 80300
+    max: 80499
   level: 10
   tmpDir: build/phpstan
   paths: