Remove freq/phase args from HHNeuronExciBlox and HHNeuronInhibBlox
#572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MasonProtter
commented
Mar 25, 2025
Comment on lines
95
to
+104
| peak_freq = ps.freq[argmax(ps.power[3:end])+2] | ||
| @test isapprox(peak_freq, 80, atol=1) | ||
| @test_broken isapprox(peak_freq, 80, atol=1) | ||
|
|
||
| # test Welch periodogram and windows | ||
| ps2 = powerspectrum(nn1, sol, "V", window = hamming) | ||
| ps3 = powerspectrum(nn1, sol, "V", method = welch_pgram, window = hanning) | ||
| peak_freq2 = ps2.freq[argmax(ps2.power[3:end])+2] | ||
| peak_freq3 = ps3.freq[argmax(ps3.power[3:end])+2] | ||
| @test isapprox(peak_freq, peak_freq2, atol=0.001) | ||
| @test isapprox(peak_freq, peak_freq3, atol=1) | ||
| @test_broken isapprox(peak_freq, peak_freq3, atol=1) |
There was a problem hiding this comment.
@gabrevaya do you have any idea why these tests might be broken by us removing the freq kwarg and how we can fix it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on a conversation with @anandpathak31 and @harisorgn. Apparently we have no use for this sinusoidal activity, and if we did, we should use a
SourceBloxfor it.