Skip to content

Conversation

alejoe91
Copy link
Contributor

@alejoe91 alejoe91 commented Jul 28, 2025

Fixes #1752

@zm711
Copy link
Contributor

zm711 commented Jul 28, 2025

@alejoe91, while we wait for the user to test this could you add to the docstring or comment above what the OneBox should look like as far as we know? So it is a three dir system in the main expt dir? Or whatever.

@h-mayorquin
Copy link
Contributor

Are we still waiting for data on this one or should I move forward with the review? I think Alessio is on vacation so feel free to reply once you are back.

@zm711
Copy link
Contributor

zm711 commented Aug 21, 2025

To me it looks like we have a spikeglx version of data but not an openephys version. So I would prefer

  1. add data of this format so we actually test
  2. we write up a note about data structure

But I think it is fine if you want to review @h-mayorquin. If you have an example at neuroconv you can still test the function without the official test.

@h-mayorquin
Copy link
Contributor

Someone shared data with us. Once Alessio is back I can take a look. I just did not understand above if a user already promised they would give us some data.

@alejoe91
Copy link
Contributor Author

Someone shared data with us. Once Alessio is back I can take a look. I just did not understand above if a user already promised they would give us some data.

Hi guys, here is the issue with the data (somehow I forgot to link it in the first place!): SpikeInterface/spikeinterface#4083

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OpenEphys: wrong ADC split with OneBox
3 participants