Slight change to fix narrative images. #401
Merged
+6
−8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The :narrative.present? call wasn't quite doing what you would expect in that method and cards without narrative text were still showing narrative image links. Sorry i missed this in the review.
I updated this to use keyword arguments and moved the logic to the caller.
The helper method could be moved to an actual helper in app/helpers/ in a follow-up PR.