Conversation
4 tasks
gsanchietti
approved these changes
Nov 24, 2025
Member
gsanchietti
left a comment
gsanchietti
left a comment
There was a problem hiding this comment.
Beware of the conflict on setup.py.
This seems to me a breaking change, maybe it's time to push the version to 2.0.0?
Contributor
Author
|
I mean we could or not, this is a non-issue, the user doesn't need to do anything so I don't see a breaking change here. |
Member
|
Let's go soft then, and do not bump it to major |
This was referenced Nov 24, 2025
Contributor
Author
|
Merge halted for now, waiting for bugfixes first. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using correct directories for netifyd v5 bump
Closes: NethServer/nethsecurity#1438