atlas: aggr function with empty tags #1097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uses a placeholder name of `unknown` if the query for an aggregate function has no exact tags. This matches the behavior of the backend.
brharrington
added a commit
to Netflix-Skunkworks/iep-apps
that referenced
this pull request
Dec 7, 2023
Uses a placeholder name of unknown if the query for an aggregate function has no exact tags. This matches the behavior of the backend. See also Netflix/spectator#1097.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses a placeholder name of
unknownif the query for an aggregate function has no exact tags. This matches the behavior of the backend.