Use result of Map.put as signal of existing entry

This is to reduce method count in the happy case
Netflix · Dec 18, 2023 · 8da917a · 8da917a
1 parent 967ee4b
commit 8da917a
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/spectator-api/src/main/java/com/netflix/spectator/api/patterns/CardinalityLimiters.java b/spectator-api/src/main/java/com/netflix/spectator/api/patterns/CardinalityLimiters.java
@@ -193,9 +193,11 @@ private void add(String s) {
         // Lock to keep hashmap consistent with counter for remaining
         lock.lock();
         try {
-          if (remaining.get() > 0 && !values.containsKey(s)) {
-            values.put(s, s);
-            remaining.decrementAndGet();
+          if (remaining.get() > 0) {
+            String existing = values.put(s, s);
+            if (existing == null) {
+              remaining.decrementAndGet();
+            }
           }
         } finally {
           lock.unlock();