debt: upgrade sqlalchemy to 1.4.36 #5945
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wssheldon
added
dependencies
mvilanova
approved these changes
Apr 30, 2025
wssheldon
changed the title
mvilanova
reviewed
May 5, 2025
| @@ -247,7 +264,13 @@ def refetch_db_session(organization_slug: str) -> Session: | |||
| @contextmanager | |||
| def get_session() -> Session: | |||
| """Context manager to ensure the session is closed after use.""" | |||
| session = SessionLocal() | |||
| schema_engine = engine.execution_options( | |||
There was a problem hiding this comment.
We should encapsulate this logic in a function that takes an org slug as a param, so we don't need to duplicate the code in get_organization_session()
…to deps/sqlalch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue in the comment has been resolved and being on
1.3significantly limits what dependencies we can use related to SQLAlchemy.