Skip to content

Fix nightly macOS CI failures - #111

Merged
davisadam10 merged 2 commits into
devfrom
fix/macos-nightly-ci
Nov 20, 2026
Merged

davisadam10 merged 2 commits into
devfrom
fix/macos-nightly-ci

Conversation

@davisadam10

Copy link
Copy Markdown
Collaborator

Problem

Nightly CI has failed since 2026-07-11 on macOS only, with no code changes. macos-latest now maps to macos-26, which changed behaviour in two places:

  1. Three tests compared generated .ocio files as exact text. The new macOS math libraries change the last digit of one serialized matrix float.
  2. test_cli_pattern_generation could read a partially written ~/OpenVPCal/prefs/*.ocio, because the built-in config was written non-atomically while pytest -n 2 workers raced. This is a plausible cause that I did not confirm in CI.

Fix

  • files_are_equal: compare .ocio files with text exact and numbers within rel_tol=1e-9, on all platforms.
  • ResourceLoader.ocio_config_path: write via temp file and os.replace.

Testing

  • With the old comparer, the three float-drift tests fail locally on macOS arm64. With the fix they pass.
  • OCIO config, OCIO utils, main and resource loader tests pass locally with CI=true. ruff is clean.
  • Not yet run on CI; will trigger workflow_dispatch on this branch.

🤖 Generated with Claude Code

…ig write

- files_are_equal compares .ocio files with a float tolerance on all platforms;
  macos-26 math libraries change the last digit of serialized matrix values.
- ResourceLoader.ocio_config_path writes the built-in config atomically so
  parallel pytest workers never read a partially written file.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@davisadam10
davisadam10 merged commit f60aba6 into dev Nov 20, 2026
12 checks passed
@davisadam10
davisadam10 deleted the fix/macos-nightly-ci branch November 20, 2026 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant