Repository navigation
Fix nightly macOS CI failures - #111
Merged
Merged
Conversation
…ig write - files_are_equal compares .ocio files with a float tolerance on all platforms; macos-26 math libraries change the last digit of serialized matrix values. - ResourceLoader.ocio_config_path writes the built-in config atomically so parallel pytest workers never read a partially written file. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Nightly CI has failed since 2026-07-11 on macOS only, with no code changes.
macos-latestnow maps to macos-26, which changed behaviour in two places:.ociofiles as exact text. The new macOS math libraries change the last digit of one serialized matrix float.test_cli_pattern_generationcould read a partially written~/OpenVPCal/prefs/*.ocio, because the built-in config was written non-atomically whilepytest -n 2workers raced. This is a plausible cause that I did not confirm in CI.Fix
files_are_equal: compare.ociofiles with text exact and numbers withinrel_tol=1e-9, on all platforms.ResourceLoader.ocio_config_path: write via temp file andos.replace.Testing
CI=true. ruff is clean.workflow_dispatchon this branch.🤖 Generated with Claude Code