Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nerv-server): extend the method of renderVodeToString to support void and array vnode #158

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion packages/nerv-server/__tests__/render.spec.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/** @jsx createElement */
import { Component, createElement } from 'nervjs'
import { Component, createElement, Fragment } from 'nervjs'
import sinon from 'sinon'
import { renderToString } from '../src'
const render = renderToString
Expand Down Expand Up @@ -92,6 +92,16 @@ describe('render', () => {
`<svg><image xlink:href="#"></image><foreignObject><div xlinkHref="#"></div></foreignObject><g><image xlink:href="#"></image></g></svg>`
)
})

it('should render Fragment child elements', () => {
const rendered = render(
<Fragment>
{[1].map(() => <div>Fragment</div>)}
</Fragment>
)
const expected = `<div>Fragment</div>`
expect(rendered).toEqual(expected)
})
})

describe('Functional component', () => {
Expand Down
7 changes: 7 additions & 0 deletions packages/nerv-server/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,14 @@ function renderVNodeToString (vnode, parent, context, isSvg?: boolean) {
context = extend(clone(context), instance.getChildContext())
}
return renderVNodeToString(rendered, vnode, context, isSvg)
} else if (Array.isArray(vnode)) {
let result = ''
vnode.forEach((vnodeItem) => {
result += renderVNodeToString(vnodeItem, {}, {})
})
return result
}
return ''
}

export function renderToString (input: any): string {
Expand Down