Skip to content

Conversation

@filliph
Copy link

@filliph filliph commented Jun 25, 2025

  • Add new functions to TomTom shim
  • Add new global functions to make waypoint management easier
  • Add new function for fetching the nearest pin

- Add new functions to TomTom shim
- Add new global functions to make waypoint management easier
- Add new function for fetching the nearest pin
@Nercus
Copy link
Owner

Nercus commented Jun 26, 2025

Hey @filliph

I'm a bit unsure about adding a global function to remove all pins or change tracking universally. I'm currently working on the next version, which introduces a new structure called "sections."
Sections are essentially groups of all active pins on the map. For example, when you load a set, a corresponding section will be added to the tracker. Pins placed manually using Ctrl+Click will be added to an "Uncategorized" section by default.
These sections will also expose a global API, allowing other addons to create and interact with them—for example, to clear pins, add new ones, track existing pins, and more. The functions exposed within each section will cover everything you've included in your PR.
The main reason for introducing this structure is to avoid potential issues when multiple pins are active. It could be problematic if one addon clears all pins indiscriminately, so I want to ensure such actions are limited to the pins created by that specific addon.

Would this approach cover your use cases?

@filliph
Copy link
Author

filliph commented Jun 26, 2025

Sounds like it 👍

I can amend the PR to only include the TomTom part and the new get closest pin function?

@filliph
Copy link
Author

filliph commented Jun 26, 2025

@Nercus also feature request while you're thinking about sections; can the pinData also be updated to store questID?

That'll allow addons to purge multiple pins that belong to one specific quest. For example if the addon sets a pin for a cave entrance and a pin for the mob inside the cave, or for phased things like the Midsummer bonfires in Blasted Lands or Arathi Highlands, where the addon might set a pin to Zidormi.

@Nercus
Copy link
Owner

Nercus commented Jun 26, 2025

I can amend the PR to only include the TomTom part and the new get closest pin function?

Don’t change it right away. Since I’m still working on building the sections system, I haven’t finalized all the functions yet. I’m not sure, but I might even add a custom section for the TomTom shim. I’ve added that to my “next version” todos list though. 😃

@Nercus also feature request while you're thinking about sections; can the pinData also be updated to store questID?

That'll allow addons to purge multiple pins that belong to one specific quest. For example if the addon sets a pin for a cave entrance and a pin for the mob inside the cave, or for phased things like the Midsummer bonfires in Blasted Lands or Arathi Highlands, where the addon might set a pin to Zidormi.

Sure! I do have a data field in mind anyway. I could add that so it can be used as a parameter in the AddPin function.

@filliph
Copy link
Author

filliph commented Jun 26, 2025

I’m not sure, but I might even add a custom section for the TomTom shim.

That would actually be really good, since then adding the ClearAllWaypoints or whatever it's called would only affect entries added by addons using the shim 👀

If more fine grained pruning is needed, the author can add full MPE support. Or wait for me to find the addon and do it for them 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants