Skip to content

Conversation

@SheffeyG
Copy link
Contributor

This change allow users to custom floating window like #685, so we can configure it as:

floating = {
    width = 0.5, -- percentage
    height = 30, -- row
    border = "single",
    ...
}

@SheffeyG SheffeyG force-pushed the feat-custom-float-window branch from 7b5d4bf to 2d19cb7 Compare January 16, 2025 08:21
@SheffeyG SheffeyG closed this Mar 14, 2025
@CKolkey CKolkey reopened this Mar 14, 2025
@CKolkey
Copy link
Member

CKolkey commented Mar 14, 2025

Nothing against this, I just am taking a break from programming due to newborn twins.

@SheffeyG
Copy link
Contributor Author

@CKolkey No worries! It's just that Noegit is one of the most powerful and extensive plugins I've used, and adding this config could involve other changes. Recently, I've been using more auto instead of float in my setup, but I will find another time to fix the type-checking issues and moving this feature on. Anyway, congratulations to you 🎉 and take your time, memories with baby twins are priceless!

P.S. This plugin has helped me a lot, and I've learned many Git commands from it. Thanks for all your hard work!

@SheffeyG SheffeyG force-pushed the feat-custom-float-window branch from 89c5349 to 857f180 Compare March 18, 2025 09:12
@SheffeyG SheffeyG marked this pull request as ready for review March 18, 2025 09:17
@SheffeyG SheffeyG force-pushed the feat-custom-float-window branch from 857f180 to 1456f7e Compare March 18, 2025 10:19
@CKolkey CKolkey force-pushed the feat-custom-float-window branch from 1572a4f to 3ceaa8c Compare May 3, 2025 17:40
@CKolkey
Copy link
Member

CKolkey commented May 3, 2025

Thanks for your contribution :)

@CKolkey CKolkey merged commit f56d490 into NeogitOrg:master May 3, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants