Review #1
Open
Review #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add class CustomNotebook. CustomNotebook add close button for tab. Add fillFile. This emulate regular record to file.
Show modal window when file is not text.
vsubhuman
commented
Dec 24, 2017
|
|
||
| def get_lines(self): | ||
| if not self.__fmt: | ||
| self.__recognize_format(self.__path) |
There was a problem hiding this comment.
Плохая идея делать функции, которые скрытно меняют какие-то поля, а потом напрямую руками эти поля использовать в других функциях. Читай: инкапсуляция, геттеры, сеттеры и т.п.
def get_lines(self):
fmt = self.__get_format()
...
def __get_format(self):
if not self.__fmt:
self.__fmt = codec.get_string_to_recognize(self.__path)
return self.__fmt
vsubhuman
commented
Dec 24, 2017
| if not self.__fmt: | ||
| self.__recognize_format(self.__path) | ||
| if self.__last_change < self.__check_update(): | ||
| with open(r'{0}'.format(self.__path), 'r', encoding='{}'.format(self.__fmt), errors='replace') as file: |
There was a problem hiding this comment.
Блин, ну я ж тебе писал уже
r'{0}'.format(x) == '{0}'.format(x) == x
'{}'.format(x) == x
vsubhuman
commented
Dec 24, 2017
| """Эта функция должна была обновлять текст на вкладке""" | ||
| self.txt.config(state='normal') | ||
| self.txt.insert(tkinter.END, self.document.get_lines()) | ||
| self.txt.config(state='disabled') |
There was a problem hiding this comment.
Стоит проверять, что документ чота вернул, прежде чем пытаться обновлять табу:
text = self.document.get_lines()
if text:
self.txt.config(state='normal')
self.txt.insert(tkinter.END, text)
self.txt.config(state='disabled')
vsubhuman
commented
Dec 24, 2017
| def get_lines(self): | ||
| if not self.__fmt: | ||
| self.__recognize_format(self.__path) | ||
| if self.__last_change < self.__check_update(): |
There was a problem hiding this comment.
last_processed_change = self.__last_change
current_last_change = os.stat(self.__path).st_mtime
if current_last_change > last_processed_change:
try:
...
except:
<handle>
else:
self.__last_change = current_last_change
vsubhuman
commented
Dec 24, 2017
| return self.__log_content | ||
| else: | ||
| self.__log_content = '' | ||
| return self.__log_content |
There was a problem hiding this comment.
Какую цель выполняет поле __log_content?
if current_last_change > last_processed_change:
with open(...) as f:
text = f.read()
self.__tail = f.tell()
return text
return None
vsubhuman
commented
Dec 24, 2017
| return self.__list_of_tab | ||
|
|
||
|
|
||
| list_of_tab = ListOfTab() |
There was a problem hiding this comment.
Это глобальная переменная. Тот факт, что ты её реализовал без слова global не делает её лучше. Думай, как сделать программу без неё.
vsubhuman
commented
Dec 24, 2017
| else: | ||
| self.__log_content = '' | ||
| return self.__log_content | ||
|
|
There was a problem hiding this comment.
Обработка ошибок?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.